Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blob directory is wrong #498

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix: blob directory is wrong #498

merged 1 commit into from
Feb 8, 2024

Conversation

thesayyn
Copy link
Collaborator

@thesayyn thesayyn commented Feb 8, 2024

google/go-containerregistry#1810 introduced this feature where blobs are written to disk_path/hex/digest but rules_oci assumed that it was disk_path/blobs/hex/digest so blobs were written to the wrong place..

@thesayyn thesayyn force-pushed the fix_blob_directory branch 2 times, most recently from 16c1a78 to 12da2a7 Compare February 8, 2024 21:13
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Should we somehow warn users that earlier versions are totally broken? How was our CI green, and how broken is it for users?

@alexeagle alexeagle merged commit e1bbc14 into main Feb 8, 2024
20 checks passed
@alexeagle alexeagle deleted the fix_blob_directory branch February 8, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants