Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mimic oci-layout in diskblobhandler #1810

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

thesayyn
Copy link
Collaborator

@thesayyn thesayyn commented Oct 11, 2023

this change makes blob disk implementation mimic oci-layout for storing blobs. This will speed up the pushing of
oci-layout images on disk to the registry by providing the oci-layout image as the storage directory.

Cross-ref: bazel-contrib/rules_oci#365

pkg/registry/blobs_disk.go Dismissed Show dismissed Hide dismissed
pkg/registry/blobs_disk.go Dismissed Show dismissed Hide dismissed
pkg/registry/blobs_disk.go Dismissed Show dismissed Hide dismissed
pkg/registry/blobs_disk.go Dismissed Show dismissed Hide dismissed
pkg/registry/blobs_disk.go Dismissed Show dismissed Hide dismissed
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #1810 (8fdd52f) into main (dbcd01c) will decrease coverage by 0.02%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##             main    #1810      +/-   ##
==========================================
- Coverage   71.88%   71.87%   -0.02%     
==========================================
  Files         122      122              
  Lines        9832     9837       +5     
==========================================
+ Hits         7068     7070       +2     
- Misses       2081     2083       +2     
- Partials      683      684       +1     
Files Coverage Δ
pkg/registry/blobs_disk.go 48.48% <44.44%> (-1.52%) ⬇️

@thesayyn
Copy link
Collaborator Author

cc @imjasonh @jonjohnsonjr

@thesayyn thesayyn changed the title fix: mimic oci-layout fix: mimic oci-layout in diskblobhandler Oct 11, 2023
@thesayyn
Copy link
Collaborator Author

thesayyn commented Nov 2, 2023

@imjasonh @jonjohnsonjr friendly ping...

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'd missed this, thanks for pinging again.

@imjasonh imjasonh merged commit c722ce9 into google:main Nov 9, 2023
18 checks passed
maximilianbraun added a commit to crossplane-contrib/xp-testing that referenced this pull request Dec 11, 2023
….17.0 (#35)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/google/go-containerregistry](https://github.com/google/go-containerregistry)
| require | minor | `v0.16.1` -> `v0.17.0` |

---

### Release Notes

<details>
<summary>google/go-containerregistry
(github.com/google/go-containerregistry)</summary>

###
[`v0.17.0`](https://github.com/google/go-containerregistry/releases/tag/v0.17.0)

[Compare
Source](https://github.com/google/go-containerregistry/compare/v0.16.1...v0.17.0)

#### What's Changed

- 🦅 Validate index architectures match children 🦅 by
[@&#8203;jonjohnsonjr](https://github.com/jonjohnsonjr) in
[google/go-containerregistry#1776
- Set Content-Length for blob uploads by
[@&#8203;jonjohnsonjr](https://github.com/jonjohnsonjr) in
[google/go-containerregistry#1781
- Don't wrap DefaultKeychain with refreshes by
[@&#8203;jonjohnsonjr](https://github.com/jonjohnsonjr) in
[google/go-containerregistry#1791
- Build releases with Go 1.21 by
[@&#8203;imjasonh](https://github.com/imjasonh) in
[google/go-containerregistry#1840
- fix: mimic oci-layout in diskblobhandler by
[@&#8203;thesayyn](https://github.com/thesayyn) in
[google/go-containerregistry#1810
- tag: add command explanation to the long help by
[@&#8203;abitrolly](https://github.com/abitrolly) in
[google/go-containerregistry#1843
- feat: implement gc command by
[@&#8203;thesayyn](https://github.com/thesayyn) in
[google/go-containerregistry#1811
- feat: allow port and disk path to be overriden by
[@&#8203;thesayyn](https://github.com/thesayyn) in
[google/go-containerregistry#1848

**Full Changelog**:
google/go-containerregistry@v0.16.1...v0.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/crossplane-contrib/xp-testing).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants