Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label.repo_name no longer returns the canonical repo name #21350

Closed
hvadehra opened this issue Feb 14, 2024 · 3 comments
Closed

Label.repo_name no longer returns the canonical repo name #21350

hvadehra opened this issue Feb 14, 2024 · 3 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) type: bug

Comments

@hvadehra
Copy link
Member

Description of the bug:

Likely culprit is a54a393

cc @c-mita

Which category does this issue belong to?

No response

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

//src/test/shell/bazel/bazel_coverage_java_test.sh and friends no longer pick up changes to java_tools

Hardcoding RULES_JAVA_REPO_NAME to "rules_java~" gets the overrides working again.

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@hvadehra hvadehra added type: bug P1 I'll work on this now. (Assignee required) labels Feb 14, 2024
@fmeum
Copy link
Collaborator

fmeum commented Feb 14, 2024

Sorry for the breakage. The scheme for canonical repo names will be different between .bazelversion Bazel and Bazel at HEAD until 7.1.0 is out.

For now, hardcoding the name is totally fine.

@fmeum
Copy link
Collaborator

fmeum commented Feb 14, 2024

Cc @meteorcloudy

bazel-io pushed a commit to bazel-io/bazel that referenced this issue Feb 14, 2024
Fixes bazelbuild#21350

Closes bazelbuild#21351.

PiperOrigin-RevId: 607063055
Change-Id: Ia80ba907d04718205658c3ad5d5fc801caf94535
github-merge-queue bot pushed a commit that referenced this issue Feb 14, 2024
Fixes #21350

Closes #21351.

Commit
eee416b

PiperOrigin-RevId: 607063055
Change-Id: Ia80ba907d04718205658c3ad5d5fc801caf94535

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@iancha1992
Copy link
Member

A fix for this issue has been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants