Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily hardcode rules_java repository name #21351

Closed
wants to merge 1 commit into from
Closed

Temporarily hardcode rules_java repository name #21351

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Feb 14, 2024

Fixes #21350

@fmeum fmeum requested a review from hvadehra February 14, 2024 17:16
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Feb 14, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Feb 14, 2024

This is analogous to

bazel/BUILD

Line 192 in 1ef93be

content = ["rules_jvm_external~~maven~maven"],
.

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 14, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 14, 2024
@fmeum fmeum deleted the patch-9 branch February 14, 2024 20:10
@fmeum
Copy link
Collaborator Author

fmeum commented Feb 14, 2024

@bazel-io fork 7.1.0

@bazel-io bazel-io mentioned this pull request Feb 14, 2024
Closed
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 14, 2024
@fmeum @bazel-io
Temporarily hardcode rules_java repository name
ab837d0 
Fixes bazelbuild#21350

Closes bazelbuild#21351.

PiperOrigin-RevId: 607063055
Change-Id: Ia80ba907d04718205658c3ad5d5fc801caf94535
@bazel-io bazel-io mentioned this pull request Feb 14, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 14, 2024
@bazel-io @fmeum
[7.1.0] Temporarily hardcode rules_java repository name (#21356)
a7a89fe 
Fixes #21350

Closes #21351.

Commit
eee416b

PiperOrigin-RevId: 607063055
Change-Id: Ia80ba907d04718205658c3ad5d5fc801caf94535

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@hvadehra hvadehra mentioned this pull request Feb 15, 2024
Closed
copybara-service bot pushed a commit that referenced this pull request Feb 16, 2024
@hvadehra @copybara-github
Remove duplication in overriding java_tools and add a test for valida…
014292b 
…ting that overriding actually works

Should help avoid issues like:

#21351

#20374

#20294 (comment)

Closes #21364.

PiperOrigin-RevId: 607785065
Change-Id: Ib8c75d597911034091c3dafd638acfe72d2eb9c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

@hvadehra hvadehra Awaiting requested review from hvadehra

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label.repo_name no longer returns the canonical repo name
2 participants
@fmeum @Wyverald