Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add higher-level TransitionFactory interface #7814

Closed
katre opened this issue Mar 22, 2019 · 0 comments
Closed

Add higher-level TransitionFactory interface #7814

katre opened this issue Mar 22, 2019 · 0 comments
Assignees
@katre
Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request

Comments

@katre
Copy link
Member

katre commented Mar 22, 2019

This is a needed prerequisite for the execution transition.
@katre katre added type: feature request P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions labels Mar 22, 2019
@katre katre self-assigned this Mar 22, 2019
@katre katre mentioned this issue Mar 22, 2019
Closed
bazel-io pushed a commit that referenced this issue Mar 22, 2019
@katre @copybara-github
Remove unused split() method.
15276d2 
Part of #7814.

Closes #7815.

PiperOrigin-RevId: 239811685
katre added a commit to katre/bazel that referenced this issue Mar 25, 2019
@katre
Add TransitionFactory interface, to be used later for creating
22cd8b4 
transitions.

Part of work on bazelbuild#7814.
@katre katre mentioned this issue Mar 25, 2019
Closed
katre added a commit to katre/bazel that referenced this issue Mar 25, 2019
@katre
Change uses of SplitTransitionProvider to TransitionFactory.
e1f6b68 
Removed SplitTransitionProvider.

part of bazelbuild#7814.
katre added a commit to katre/bazel that referenced this issue Mar 25, 2019
@katre
Change uses of SplitTransitionProvider to TransitionFactory.
ffe063e 
Removed SplitTransitionProvider.

part of bazelbuild#7814.
bazel-io pushed a commit that referenced this issue Mar 25, 2019
@katre @copybara-github
Move checking for host transitions to a few centralized places.
0eee8c5 
This is a prerequisite for adding transition factories.

Part of #7814.

PiperOrigin-RevId: 240172034
bazel-io pushed a commit that referenced this issue Mar 25, 2019
@katre @copybara-github
Add an (unused) AttributeMap argument to Attribute.getConfigurationTr…
5494081 
…ansition.

This is to prepare Attribute to use TransitionFactory instead of a single
ConfigurationTransition.

Part of #7814.

PiperOrigin-RevId: 240195652
katre added a commit to katre/bazel that referenced this issue Mar 25, 2019
@katre @copybara-github
Add TransitionFactory interface, to be used later for creating
c30785a 
transitions.

Part of work on bazelbuild#7814.

Closes bazelbuild#7825.

PiperOrigin-RevId: 240196293
katre added a commit to katre/bazel that referenced this issue Mar 25, 2019
@katre
Add useful implementations of TransitionFactory.
d779c13 
Eventually, the FooTransition classes should be refactored to be
FooTransitionFactory directly, but this can be done after all uses are
updated.

Part of work on bazelbuild#7814.
@katre katre mentioned this issue Mar 25, 2019
Closed
katre added a commit to katre/bazel that referenced this issue Mar 25, 2019
@katre
Change uses of SplitTransitionProvider to TransitionFactory.
d5fc444 
Removed SplitTransitionProvider.

Part of bazelbuild#7814.
@katre katre mentioned this issue Mar 25, 2019
Closed
katre added a commit to katre/bazel that referenced this issue Mar 26, 2019
@katre
Change uses of SplitTransitionProvider to TransitionFactory.
5f9e26c 
Removed SplitTransitionProvider.

Part of bazelbuild#7814.
katre added a commit to katre/bazel that referenced this issue Mar 26, 2019
@katre
Add useful implementations of TransitionFactory.
0408420 
Eventually, the FooTransition classes should be refactored to be
FooTransitionFactory directly, but this can be done after all uses are
updated.

Part of work on bazelbuild#7814.
katre added a commit to katre/bazel that referenced this issue Mar 26, 2019
@katre
Update Attribute to use a single TransitionFactory for patch and split
15947b6 
transitions.

Part of work on bazelbuild#7814.
bazel-io pushed a commit that referenced this issue Mar 26, 2019
@katre @copybara-github
Add useful implementations of TransitionFactory.
74d929a 
Eventually, the FooTransition classes should be refactored to be
FooTransitionFactory directly, but this can be done after all uses are
updated.

Part of work on #7814.

Closes #7832.

PiperOrigin-RevId: 240412387
bazel-io pushed a commit that referenced this issue Mar 27, 2019
@katre @copybara-github
Change uses of SplitTransitionProvider to TransitionFactory.
0a9e1ed 
Removed SplitTransitionProvider.

Part of #7814.

Closes #7833.

PiperOrigin-RevId: 240598880
katre added a commit to katre/bazel that referenced this issue Mar 27, 2019
@katre
Update Attribute to use a single TransitionFactory for patch and split
121bf2e 
transitions.

Part of work on bazelbuild#7814.
@katre katre mentioned this issue Mar 27, 2019
Closed
bazel-io pushed a commit that referenced this issue Mar 28, 2019
@katre @copybara-github
Update Attribute to use a single TransitionFactory for patch and split
5adcd3e 
transitions.

Part of work on #7814.

Closes #7859.

PiperOrigin-RevId: 240797521
katre added a commit to katre/bazel that referenced this issue Mar 28, 2019
@katre
Add new ComposingTransitionFactory class.
567f5e9 
Part of bazelbuild#7814.
@katre katre mentioned this issue Mar 28, 2019
Closed
bazel-io pushed a commit that referenced this issue Mar 29, 2019
@katre @copybara-github
Update all attributes which use the host transition to use the host t…
ffb65c8 
…ransition

factory.

This will help ensure that calls to TransitionFactory.isHost will always be
correct.

Part of #7814.

PiperOrigin-RevId: 240977747
bazel-io pushed a commit that referenced this issue Mar 29, 2019
@katre @copybara-github
Add new ComposingTransitionFactory class.
6306179 
Part of #7814.

Closes #7877.

PiperOrigin-RevId: 241032661
katre added a commit to katre/bazel that referenced this issue Apr 1, 2019
@katre
Replace ComposingTransition.decomposeTransitions with the visitor
6442fdc 
pattern.

Part of the work on bazelbuild#7814.
@katre katre mentioned this issue Apr 1, 2019
Closed
katre added a commit to katre/bazel that referenced this issue Apr 1, 2019
@katre
Remove the TransitionFactoryData interface.
76504ce 
Part of bazelbuild#7814.
@katre katre mentioned this issue Apr 1, 2019
Closed
bazel-io pushed a commit that referenced this issue Apr 1, 2019
@katre @copybara-github
Replace ComposingTransition.decomposeTransitions with the visitor
a05d5b6 
pattern.

Part of the work on #7814.

Closes #7912.

PiperOrigin-RevId: 241378193
bazel-io pushed a commit that referenced this issue Apr 1, 2019
@katre @copybara-github
Remove the TransitionFactoryData interface.
9e23d96 
Part of #7814.

Closes #7915.

PiperOrigin-RevId: 241401471
katre added a commit to katre/bazel that referenced this issue Apr 2, 2019
@katre
Rename RuleTransitionData to AttributeTransitionData.
b97e52a 
Rule transitions will use a different data holder.

part of work on bazelbuild#7814.
@katre katre mentioned this issue Apr 2, 2019
Closed
bazel-io pushed a commit that referenced this issue Apr 2, 2019
@katre @copybara-github
Rename RuleTransitionData to AttributeTransitionData.
2c0dece 
Rule transitions will use a different data holder.

part of work on #7814.

Closes #7918.

PiperOrigin-RevId: 241541559
katre added a commit to katre/bazel that referenced this issue Apr 2, 2019
@katre
Convert uses of RuleTransitionFactory to TransitionFactory.
79e11d3 
Part of bazelbuild#7814.
@katre katre mentioned this issue Apr 2, 2019
Closed
bazel-io pushed a commit that referenced this issue Apr 2, 2019
@katre @copybara-github
Remove obsolete TODO.
322e98b 
Part of #7814.

PiperOrigin-RevId: 241548979
bazel-io pushed a commit that referenced this issue Apr 2, 2019
@katre @copybara-github
Remove Attribute.hasSplitConfigurationTransition.
e8f5a98 
Part of #7814.

PiperOrigin-RevId: 241564844
bazel-io pushed a commit that referenced this issue Apr 2, 2019
@katre @copybara-github
Remove Attribute.hasHostConfigurationTransition.
b44167f 
Part of #7814.

PiperOrigin-RevId: 241576383
bazel-io pushed a commit that referenced this issue Apr 2, 2019
@katre @copybara-github
Remove Attribute.cfg(ConfigurationTransition).
98a09b6 
Also removed the now-unused Attribute.StaticTransitionFactory.

Part of work on #7814.

PiperOrigin-RevId: 241587484
bazel-io pushed a commit that referenced this issue Apr 3, 2019
@katre @copybara-github
Convert uses of RuleTransitionFactory to TransitionFactory.
b3b3e8b 
Part of #7814.

Closes #7922.

PiperOrigin-RevId: 241744479
@katre katre closed this as completed Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katre