-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TransitionFactory interface, to be used later for creating #7825
Conversation
transitions. Part of work on bazelbuild#7814.
import com.google.devtools.build.lib.analysis.config.transitions.TransitionFactory.TransitionFactoryData; | ||
|
||
/** | ||
* Helper for the types of transitions that are statically declared but must be instantiated for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since, as I understand, we're going to funnel all transitions through this interface, even if they can be instantiated statically, can we provide more context for this javadoc?
Also, let's reference
bazel/src/main/java/com/google/devtools/build/lib/analysis/config/transitions/PatchTransition.java
Lines 31 to 33 in 1f684e1
* input build options and any immutable member fields. Implementations must also override | |
* {@link Object#equals} and {@link Object#hashCode} unless exclusively accessed as | |
* singletons. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more details and added that note.
I'm still not entirely sure if everything will be factories, or if we'll still have static transitions. I can come back and update this Javadoc once a decision becomes clear during the implementation.
transitions.
Part of work on #7814.