import_deps_checker tests aren't compatible with the current Bazel JDK

[katre]

Because tests under //src/java_tools haven't been run, the code has decayed badly. I don't understand how to fix these.

To reproduce:

$ bazel build --nokeep_going  //src/java_tools/import_deps_checker/javatests/...
INFO: Analysed 31 targets (0 packages loaded, 0 targets configured).
INFO: Found 31 targets...
ERROR: missing input file '@local_jdk//:jre/lib/rt.jar'
ERROR: /usr/local/google/home/jcater/repos/bazel/src/java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps/BUILD:84:1: //src/java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps:DepsCheckerClassVisitorTest: missing input file '@local_jdk//:jre/lib/rt.jar'
ERROR: /usr/local/google/home/jcater/repos/bazel/src/java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps/BUILD:84:1 1 input file(s) do not exist
INFO: Elapsed time: 0.325s, Critical Path: 0.02s
INFO: 0 processes.
FAILED: Build did NOT complete successfully

I suspect that even cleaning this up to build, the tests still won't actually pass.

[katre]

In #8164, I add all tests under //src/java_tools except the tests for import_deps_checker. Be sure to re-enable the tests when this is fixed.

[katre]

Buildtools also fails under jdk8. I don't know if there's a way to fix this for both.

[iirina]

@katre can you also link a log or an error snippet for buildtools?

[iirina]

I found the buildkite run: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/2717#533453ca-1692-4357-a693-15e7257602b1

Tests are failing with java.lang.NoSuchFieldError: ANNOTATION_PROCESSOR_MODULE_PATH

[cushon]

@kevin1e100 FYI for import_deps_checker.

@local_jdk shouldn't be used anymore, but even if the test resolves a JDK correctly rt.jar doesn't exist for JDK > 8.

I would try dropping in @bazel_tools//tools/jdk:platformclasspath instead of @local_jdk//:jre/lib/rt.jar and see if that works.

java.lang.NoSuchFieldError: ANNOTATION_PROCESSOR_MODULE_PATH

That probably indicates the necessary --patch-module= flags aren't getting set, or are being set incorrectly.

[meisterT]

This seems to be fixed.

[meteorcloudy]

Should the following tests be re-enabled again:

bazel/.bazelci/postsubmit.yml

Lines 82 to 83 in 415f85a

	# Re-enable once fixed: https://github.com/bazelbuild/bazel/issues/8162
	- "-//src/java_tools/import_deps_checker/..."

[meisterT]

likely, let's try?

[comius]

@meisterT did you try?

[meisterT]

Nope, I though @meteorcloudy did, but I don't see a sign. Do you want to try it?

[meteorcloudy]

Sorry, I didn't, it was a drop-by comment when I was fixing something else.

[comius]

#16491

[github-actions]

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.