Fix javatools #8164
Closed
Fix javatools #8164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iirina
approved these changes
Apr 26, 2019
|
buildjar is also not compatible with jdk8, so removed those tests on ubuntu1404 and ubuntu1604 |
iirina
reviewed
Apr 26, 2019
| @@ -72,10 +64,6 @@ java_test( | |||
| data = [ | |||
| "//third_party/java/jdk/langtools:javac_jar", | |||
| ], | |||
| jvm_flags = [ | |||
| # Simulates how Bazel invokes turbine | |||
| "-Xbootclasspath/p:$(location //third_party/java/jdk/langtools:javac_jar)", | |||
There was a problem hiding this comment.
Why did you remove these flags? They may be the reason why the buildtools tests are failing on jdk8
There was a problem hiding this comment.
Because the build fails with them on JDK11.
There was a problem hiding this comment.
OK, I think it's ok to disable the tests for JDK8 for the time being... I'll investigate the issue on Monday. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.