Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cpp:default-toolchain #15003

Closed

Conversation

keith
Copy link
Member

@keith keith commented Mar 8, 2022

This was disabled in bazel 1.0 but there were still a lot of remnants
around.

#8546

@keith
Copy link
Member Author

keith commented Mar 8, 2022

I still see these references so I'm interested to see how CI fails

actual = "@bazel_tools//tools/cpp:default-toolchain",

bind(name = "cc_toolchain", actual = "@bazel_tools//tools/cpp:default-toolchain")

@keith
Copy link
Member Author

keith commented Mar 16, 2022

@oquenchil given no failures here do you have more context on what should break here?

@sgowroji sgowroji added the team-Rules-CPP Issues for C++ rules label Mar 22, 2022
@keith keith marked this pull request as ready for review April 16, 2022 03:32
@keith keith requested a review from lberki as a code owner April 16, 2022 03:32
@lberki lberki requested review from oquenchil and removed request for lberki April 19, 2022 08:05
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewpaekgoogle and others added 2 commits April 21, 2022 14:07
…eEventRequest and PublishBuildToolEventStreamRequest protos.

Closes bazelbuild#15247.
This was disabled in bazel 1.0 but there were still a lot of remnants
around.

bazelbuild#8546
@keith keith force-pushed the ks/remove-cpp-default-toolchain branch from 847b390 to 19e8873 Compare April 21, 2022 19:47
@bazel-io bazel-io closed this in 1727361 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants