Update use of default_java_toolchain in "Java and Bazel" to work correctly
#15009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rly. There are really two changes here: 1. Fix the reference to `//tools/jdk:remote_jdk11` to have `@bazel_tools`. Without this, a direct copy/paste will fail to even build. 2. Change from `JDK9_JVM_OPTS` to `BASE_JDK9_JVM_OPTS` as the former includes `--patch-module=java.compiler=` which overrides `source_version` and can also cause build failures. See bazelbuild#14474 (comment) for an example.
kjcartledge
changed the title
default_java_toolchain to work properlydefault_java_toolchain in "Java and Bazel" to work correctly
comius
approved these changes
Mar 10, 2022
|
Thanks @kjcartledge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are really two changes here:
//tools/jdk:remote_jdk11to have@bazel_tools. Without this, a direct copy/paste will fail to even build.JDK9_JVM_OPTStoBASE_JDK9_JVM_OPTSas the former includes--patch-module=java.compiler=which overridessource_versionand can also cause build failures. See this issue for an example.