Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update use of default_java_toolchain in "Java and Bazel" to work correctly #15009

Closed
wants to merge 1 commit into from
Closed

Update use of default_java_toolchain in "Java and Bazel" to work correctly #15009

wants to merge 1 commit into from

Commits on Mar 9, 2022

  1. Update Java and Bazel's use of default_java_toolchain to work prope… 

    …rly.

There are really two changes here:
  1. Fix the reference to `//tools/jdk:remote_jdk11` to have `@bazel_tools`. Without this, a direct copy/paste will fail to even build.
  2. Change from `JDK9_JVM_OPTS` to `BASE_JDK9_JVM_OPTS` as the former includes `--patch-module=java.compiler=` which overrides `source_version` and can also cause build failures. See bazelbuild#14474 (comment) for an example.
    @kjcartledge
    kjcartledge committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    c9ac4b3 View commit details
    Browse the repository at this point in the history