Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Step 1] Upgrade Google Auth Version #15215

Closed

Conversation

ThomasCJY
Copy link
Contributor

@ThomasCJY ThomasCJY commented Apr 11, 2022

upgrade google auth to use the latest v1.6.0 instead of the outdated 0.17 in bazel

pt 1: Add Gson and upgrade Auth (third_party only changes)

part of #15176

@sgowroji sgowroji added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Apr 12, 2022
@@ -163,8 +163,10 @@ distrib_java_import(
jars = [
"api_client/google-api-client-1.22.0.jar",
"api_client/google-api-client-jackson2-1.22.0.jar",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove two jackson2 jars in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't that require us to update test code import com.google.api.client.json.jackson2.JacksonFactory; as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I thought only :jackson2 is required for the test code. Please add them back and we are ready to merge!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr updated

"api_client/google-http-client-1.22.0-SNAPSHOT.jar",
"api_client/google-http-client-jackson2-1.22.0.jar",
"api_client/google-http-client-gson-1.22.0.jar",
],
runtime_deps = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need :gson here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. updated

@ThomasCJY ThomasCJY requested a review from coeuvre April 13, 2022 18:03
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy Can you help import this PR?

@meteorcloudy
Copy link
Member

@ThomasCJY Can you squash all commits into a single one? That's easier for importing.

gson

add back jackson
@ThomasCJY
Copy link
Contributor Author

@meteorcloudy @coeuvre ^PTAL

@bazel-io bazel-io closed this in 9e86437 Apr 19, 2022
bazel-io pushed a commit that referenced this pull request Apr 20, 2022
Follow up for #15215 and Step two for #15176

Closes #15295.

PiperOrigin-RevId: 443050332
coeuvre pushed a commit to coeuvre/bazel that referenced this pull request May 2, 2022
third party only changes

gson

add back jackson

Partial commit for third_party/*, see bazelbuild#15215.

Closes bazelbuild#15215

Signed-off-by: Yun Peng <pcloudy@google.com>
coeuvre pushed a commit to coeuvre/bazel that referenced this pull request May 2, 2022
Follow up for bazelbuild#15215 and Step two for bazelbuild#15176

Closes bazelbuild#15295.

PiperOrigin-RevId: 443050332
ckolli5 pushed a commit that referenced this pull request May 9, 2022
* [Step 1] Upgrade Google Auth Version

third party only changes

gson

add back jackson

Partial commit for third_party/*, see #15215.

Closes #15215

Signed-off-by: Yun Peng <pcloudy@google.com>

* [Step 2] Update non-third party change for jackson2

Follow up for #15215 and Step two for #15176

Closes #15295.

PiperOrigin-RevId: 443050332

* clean up

Partial commit for third_party/*, see #15301.

Closes: #15301

Signed-off-by: Yun Peng <pcloudy@google.com>

Co-authored-by: Thomas Chen <jchen@snapchat.com>
Co-authored-by: ThomasCJY <thomascjy93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants