[Step 1] Upgrade Google Auth Version #15215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
the
team-Remote-Exec
coeuvre
requested changes
Apr 13, 2022
| @@ -163,8 +163,10 @@ distrib_java_import( | |||
| jars = [ | |||
| "api_client/google-api-client-1.22.0.jar", | |||
| "api_client/google-api-client-jackson2-1.22.0.jar", | |||
There was a problem hiding this comment.
I think we can remove two jackson2 jars in this PR.
There was a problem hiding this comment.
wouldn't that require us to update test code import com.google.api.client.json.jackson2.JacksonFactory; as well?
There was a problem hiding this comment.
Right. I thought only :jackson2 is required for the test code. Please add them back and we are ready to merge!
| "api_client/google-http-client-1.22.0-SNAPSHOT.jar", | ||
| "api_client/google-http-client-jackson2-1.22.0.jar", | ||
| "api_client/google-http-client-gson-1.22.0.jar", | ||
| ], | ||
| runtime_deps = [ |
coeuvre
approved these changes
Apr 14, 2022
|
@ThomasCJY Can you squash all commits into a single one? That's easier for importing. |
gson add back jackson
ThomasCJY
force-pushed
the
jchen-updateAuthVersion2
branch
from
fa7f360
to
dac621f
Compare
|
@meteorcloudy @coeuvre ^PTAL |
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
May 2, 2022
third party only changes gson add back jackson Partial commit for third_party/*, see bazelbuild#15215. Closes bazelbuild#15215 Signed-off-by: Yun Peng <pcloudy@google.com>
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
May 2, 2022
Follow up for bazelbuild#15215 and Step two for bazelbuild#15176 Closes bazelbuild#15295. PiperOrigin-RevId: 443050332
ckolli5
pushed a commit
that referenced
this pull request
May 9, 2022
* [Step 1] Upgrade Google Auth Version third party only changes gson add back jackson Partial commit for third_party/*, see #15215. Closes #15215 Signed-off-by: Yun Peng <pcloudy@google.com> * [Step 2] Update non-third party change for jackson2 Follow up for #15215 and Step two for #15176 Closes #15295. PiperOrigin-RevId: 443050332 * clean up Partial commit for third_party/*, see #15301. Closes: #15301 Signed-off-by: Yun Peng <pcloudy@google.com> Co-authored-by: Thomas Chen <jchen@snapchat.com> Co-authored-by: ThomasCJY <thomascjy93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade google auth to use the latest v1.6.0 instead of the outdated 0.17 in bazel
pt 1: Add Gson and upgrade Auth (third_party only changes)
part of #15176