-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Step 1] Upgrade Google Auth Version #15215
Conversation
@@ -163,8 +163,10 @@ distrib_java_import( | |||
jars = [ | |||
"api_client/google-api-client-1.22.0.jar", | |||
"api_client/google-api-client-jackson2-1.22.0.jar", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove two jackson2 jars in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't that require us to update test code import com.google.api.client.json.jackson2.JacksonFactory;
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I thought only :jackson2
is required for the test code. Please add them back and we are ready to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr updated
"api_client/google-http-client-1.22.0-SNAPSHOT.jar", | ||
"api_client/google-http-client-jackson2-1.22.0.jar", | ||
"api_client/google-http-client-gson-1.22.0.jar", | ||
], | ||
runtime_deps = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need :gson
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@meteorcloudy Can you help import this PR?
@ThomasCJY Can you squash all commits into a single one? That's easier for importing. |
gson add back jackson
fa7f360
to
dac621f
Compare
@meteorcloudy @coeuvre ^PTAL |
third party only changes gson add back jackson Partial commit for third_party/*, see bazelbuild#15215. Closes bazelbuild#15215 Signed-off-by: Yun Peng <pcloudy@google.com>
Follow up for bazelbuild#15215 and Step two for bazelbuild#15176 Closes bazelbuild#15295. PiperOrigin-RevId: 443050332
* [Step 1] Upgrade Google Auth Version third party only changes gson add back jackson Partial commit for third_party/*, see #15215. Closes #15215 Signed-off-by: Yun Peng <pcloudy@google.com> * [Step 2] Update non-third party change for jackson2 Follow up for #15215 and Step two for #15176 Closes #15295. PiperOrigin-RevId: 443050332 * clean up Partial commit for third_party/*, see #15301. Closes: #15301 Signed-off-by: Yun Peng <pcloudy@google.com> Co-authored-by: Thomas Chen <jchen@snapchat.com> Co-authored-by: ThomasCJY <thomascjy93@gmail.com>
upgrade google auth to use the latest v1.6.0 instead of the outdated 0.17 in bazel
pt 1: Add Gson and upgrade Auth (third_party only changes)
part of #15176