Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Step 2] Update non-third party change for jackson2 #15295

Closed

Conversation

ThomasCJY
Copy link
Contributor

@ThomasCJY ThomasCJY commented Apr 19, 2022

Follow up for #15215 and Step two for #15176

@ThomasCJY ThomasCJY requested a review from a team as a code owner April 19, 2022 18:28
@ThomasCJY
Copy link
Contributor Author

@coeuvre @meteorcloudy ^ ptal

@ckolli5 ckolli5 added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Apr 19, 2022
@ckolli5 ckolli5 requested a review from coeuvre April 19, 2022 20:44
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in d8feb4d Apr 20, 2022
@ThomasCJY ThomasCJY mentioned this pull request Apr 20, 2022
coeuvre pushed a commit to coeuvre/bazel that referenced this pull request May 2, 2022
Follow up for bazelbuild#15215 and Step two for bazelbuild#15176

Closes bazelbuild#15295.

PiperOrigin-RevId: 443050332
ckolli5 pushed a commit that referenced this pull request May 9, 2022
* [Step 1] Upgrade Google Auth Version

third party only changes

gson

add back jackson

Partial commit for third_party/*, see #15215.

Closes #15215

Signed-off-by: Yun Peng <pcloudy@google.com>

* [Step 2] Update non-third party change for jackson2

Follow up for #15215 and Step two for #15176

Closes #15295.

PiperOrigin-RevId: 443050332

* clean up

Partial commit for third_party/*, see #15301.

Closes: #15301

Signed-off-by: Yun Peng <pcloudy@google.com>

Co-authored-by: Thomas Chen <jchen@snapchat.com>
Co-authored-by: ThomasCJY <thomascjy93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants