Fixes _module_repo_name when building with Bazel@HEAD or Bazel 7.1 #21324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
fmeum
approved these changes
Feb 13, 2024
sgowroji
added
the
team-ExternalDeps
github-actions
bot
removed
the
awaiting-review
meteorcloudy
added a commit
to meteorcloudy/bazel
that referenced
this pull request
Feb 14, 2024
If `get_canonical_repo_name` no longer returns the repo name with version due to containing bazelbuild@a54a393, the `_module_repo_name` should not either. Fixes: bazelbuild#21292 Closes bazelbuild#21324. PiperOrigin-RevId: 606646238 Change-Id: I8835a84842c2c66929586b39156eb9f5a541652f
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
…21349) Fixes //src/test/py/bazel:bazel_vendor_test in ipv6-only environment … …on macOS https://buildkite.com/bazel/bazel-bazel-macos-ninja/builds/514 PiperOrigin-RevId: 606599015 Change-Id: I36a8534d6676bc5c3c9a0157eea28fb033e9cf3e ------- Fixes //src/test/shell/bazel:bazel_test_test in ipv6-only environment… … on macOS https://buildkite.com/bazel/bazel-bazel-macos-ninja/builds/517 PiperOrigin-RevId: 606603953 Change-Id: Id730a0457e2a6bc1ac5371cbbce25c4acd25ab9d ----- Fixes _module_repo_name when building with Bazel@HEAD or Bazel 7.1 If `get_canonical_repo_name` no longer returns the repo name with version due to containing a54a393, the `_module_repo_name` should not either. Fixes: #21292 Closes #21324. PiperOrigin-RevId: 606646238 Change-Id: I8835a84842c2c66929586b39156eb9f5a541652f ----- Make sure generate_dist_lockfile works in ipv6-only environment Fixes https://buildkite.com/bazel/bazel-bazel-macos-ninja/builds/534#018da46c-5aff-45ea-8b66-937e676b09b2 PiperOrigin-RevId: 606951013 Change-Id: I9336c9b8a173ed464b0fd3dab22a5dc1614b4c62 ---- Fix googleapis and remoteapis sources in bootstrap distfile Previously, their sources are included as external repos and mapped to third_party, after this change, their sources are directly included under the third_party directory. This change is needed because a54a393 broke the mapping mechanism which depends on the canonical repository name. Fixes //src/test/shell/bazel:bazel_bootstrap_distfile_tar_test with Bazel@HEAD and Bazel@7.1 https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3657#018da594-e743-44da-8f76-782a8e5c86b1 Related #21292 PiperOrigin-RevId: 606960533 Change-Id: Ia4a81d5730e04964bc06c8f8ee2685364ce8623b
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
Feb 23, 2024
If `get_canonical_repo_name` no longer returns the repo name with version due to containing bazelbuild@a54a393, the `_module_repo_name` should not either. Fixes: bazelbuild#21292 Closes bazelbuild#21324. PiperOrigin-RevId: 606646238 Change-Id: I8835a84842c2c66929586b39156eb9f5a541652f
fweikert
added a commit
that referenced
this pull request
Feb 23, 2024
…21486) If `get_canonical_repo_name` no longer returns the repo name with version due to containing a54a393, the `_module_repo_name` should not either. Fixes: #21292 Closes #21324. PiperOrigin-RevId: 606646238 Change-Id: I8835a84842c2c66929586b39156eb9f5a541652f Co-authored-by: Yun Peng <pcloudy@google.com>
fweikert
added a commit
to fweikert/bazel
that referenced
this pull request
Mar 5, 2024
…azelbuild#21486) If `get_canonical_repo_name` no longer returns the repo name with version due to containing bazelbuild@a54a393, the `_module_repo_name` should not either. Fixes: bazelbuild#21292 Closes bazelbuild#21324. PiperOrigin-RevId: 606646238 Change-Id: I8835a84842c2c66929586b39156eb9f5a541652f Co-authored-by: Yun Peng <pcloudy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
get_canonical_repo_nameno longer returns the repo name with version due to containing a54a393, the_module_repo_nameshould not either.Fixes: #21292