Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes _module_repo_name when building with Bazel@HEAD or Bazel 7.1 (#… #21570

Conversation

fweikert
Copy link
Member

@fweikert fweikert commented Mar 5, 2024

…21486)

If get_canonical_repo_name no longer returns the repo name with version due to containing
a54a393, the _module_repo_name should not either.

Fixes: #21292

Closes #21324.

PiperOrigin-RevId: 606646238
Change-Id: I8835a84842c2c66929586b39156eb9f5a541652f

…azelbuild#21486)

If `get_canonical_repo_name` no longer returns the repo name with
version due to containing
bazelbuild@a54a393,
the `_module_repo_name` should not either.

Fixes: bazelbuild#21292

Closes bazelbuild#21324.

PiperOrigin-RevId: 606646238
Change-Id: I8835a84842c2c66929586b39156eb9f5a541652f

Co-authored-by: Yun Peng <pcloudy@google.com>
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Mar 5, 2024
@fweikert fweikert closed this Mar 5, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant