Make launcher_maker cross-platform
#23731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`//tools/launcher:launcher_maker` produces launcher *for* Windows, but there is no reason why it must *run on* Windows. By making it runnable on all platforms, `*_binary` targets can be built *for* Windows from any platform assuming that a suitable cross-compiling C++ toolchain is available.
github-actions
bot
added
the
awaiting-review
meteorcloudy
added
the
awaiting-PR-merge
|
@bazel-io fork 7.4.0 |
rickeylev
approved these changes
Sep 25, 2024
github-actions
bot
removed
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 26, 2024
`//tools/launcher:launcher_maker` produces launchers *for* Windows, but there is no reason why it must *run on* Windows. By making it runnable on all platforms, `*_binary` targets can be built *for* Windows from any platform assuming that a suitable cross-compiling C++ toolchain is available. Closes bazelbuild#23731. PiperOrigin-RevId: 679251350 Change-Id: I1b380d5b28a616ace88a3b049a2b4554aa209ae3
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
`//tools/launcher:launcher_maker` produces launchers *for* Windows, but there is no reason why it must *run on* Windows. By making it runnable on all platforms, `*_binary` targets can be built *for* Windows from any platform assuming that a suitable cross-compiling C++ toolchain is available. Closes #23731. PiperOrigin-RevId: 679251350 Change-Id: I1b380d5b28a616ace88a3b049a2b4554aa209ae3 Commit 108f117 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
|
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//tools/launcher:launcher_makerproduces launchers for Windows, but there is no reason why it must run on Windows. By making it runnable on all platforms,*_binarytargets can be built for Windows from any platform assuming that a suitable cross-compiling C++ toolchain is available.