Starlarkify sh_binary and sh_test
#23732
Closed
+431
−1,043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
sh-binary
branch
7 times, most recently
from
f958b01
to
a68d2b1
Compare
fmeum
force-pushed
the
sh-binary
branch
5 times, most recently
from
f636a77
to
629fc59
Compare
|
@comius I had to disable doc generation on this PR for CI to get anywhere (see the last commit). Is there anything I need to do to get references such as |
fmeum
force-pushed
the
sh-binary
branch
15 times, most recently
from
dd24d0c
to
0341a0f
Compare
fmeum
commented
Oct 1, 2024
| @@ -90,7 +90,7 @@ working directory. If run directly (using the <code>standalone</code> strategy), | |||
| results, including caching policies and environment variables. Tests generally need to be run | |||
| after the build is complete and on the target architecture, whereas genrules are executed during | |||
| the build and on the exec architecture (the two may be different). If you need a general purpose | |||
| testing rule, use <a href="${link sh_test}"><code>sh_test</code></a>. | |||
| testing rule, use <a href="shell#sh_test"><code>sh_test</code></a>. | |||
There was a problem hiding this comment.
I couldn't get ${link sh_test} to work and dropped it since it only occurs a single time in the docs.
fmeum
requested review from
gregestren and
meteorcloudy
and removed request for
a team and
gregestren
github-actions
bot
added
team-Configurability
fmeum
commented
Oct 1, 2024
meteorcloudy
approved these changes
Oct 1, 2024
comius
added
awaiting-PR-merge
|
Could you please rebase this? |
|
Migrated to https://github.com/bazelbuild/rules_shell. |
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native
sh_{binary,test}incorrectly used the execution platform instead of the target platform to determine whether to use a launcher. The starlarkified rule obtains the launcher from thesh_toolchain, which now has one instance registered for each common Bazel platform. Users can add additional toolchains as needed.Fixes #23658
RELNOTES:
sh_binaryandsh_testcan now be built for Windows on non-Windows execution platforms (and vice versa).