Fix version resolution in AutoloadSymbols
#23936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic picked the first instead of the highest version due to a typo.
|
@bazel-io flag |
github-actions
bot
added
the
awaiting-review
bazel-io
added
the
potential release blocker
|
@cushon FYI, IntelliJ flagged this, but I wonder whether there is an errorprone check for it that could have prevented this issue. |
|
Not sure how hard it would be to add a test for this? |
meteorcloudy
added
awaiting-PR-merge
I don't think we have one, but it's a good idea, I filed a FR |
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io fork 8.0.0 |
bazel-io
removed
the
potential release blocker
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Oct 10, 2024
The logic picked the first instead of the highest version due to a typo. Closes bazelbuild#23936. PiperOrigin-RevId: 684528776 Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9
|
@bazel-io fork 7.4.0 |
comius
pushed a commit
to comius/bazel
that referenced
this pull request
Oct 14, 2024
The logic picked the first instead of the highest version due to a typo. Closes bazelbuild#23936. PiperOrigin-RevId: 684528776 Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
The logic picked the first instead of the highest version due to a typo. Closes #23936. PiperOrigin-RevId: 684528776 Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
|
The changes in this PR have been included in Bazel 8.0.0 RC2. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic picked the first instead of the highest version due to a typo.