Skip to content

Commit

Permalink
Fix version resolution in AutoloadSymbols
Browse files Browse the repository at this point in the history
The logic picked the first instead of the highest version due to a typo.

Closes bazelbuild#23936.

PiperOrigin-RevId: 684528776
Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9
  • Loading branch information
fmeum authored and comius committed Oct 14, 2024
1 parent 067ce4d commit e862e36
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ public ImmutableMap<String, BzlLoadValue.Key> getLoadKeys(SkyFunction.Environmen
toImmutableMap(
ModuleKey::getName,
moduleKey -> moduleKey,
(m1, m2) -> m1.getVersion().compareTo(m2.getVersion()) >= 0 ? m1 : m1));
(m1, m2) -> m1.getVersion().compareTo(m2.getVersion()) >= 0 ? m1 : m2));
RepositoryMapping repositoryMapping =
RepositoryMapping.create(
highestVersions.entrySet().stream()
Expand Down

0 comments on commit e862e36

Please sign in to comment.