-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Truth to 0.44. #8150
Update Truth to 0.44. #8150
Conversation
This is necessary for some forthcoming changes that migrate to methods introduced in that version: https://github.com/google/truth/releases/tag/release_0_44 While here, move diffutils from runtime_deps to deps. This is unlikely to matter in practice, but in principle it's the right thing, and it *might* matter if static analysis or other build tools (-Xlint:all?) went digging into the deps of Truth at compile time. Such problems (albeit when the dependency's API is publicly visible through the using library) are what prompted the creation of java_import#deps (internal Google bug 23781162). For other problems (that might also not apply here), see google/guava#2721
@philwo was working on this, in #8144.
And then:
To which @ahumesky replied:
|
Thanks. And oops, I thought I had noted somewhere public that Truth doesn't actually require Guava 27.0.1: It just uses it for good hygiene. I'll see if I can dig up what I wrote. Still, if you'd prefer to wait for a full upgrade, that's OK with me. FWIW, tests do appear to be passing. |
Eh, I can't find what I wrote, but: Truth does require 25.1 or newer (for |
You're right, the tests pass, which is the important bit. I will merge this shortly, and then we can unblock your other changes. Thanks for helping out with this! |
This was merged as 568048b |
This is necessary for some forthcoming changes that migrate to methods introduced in that version:
https://github.com/google/truth/releases/tag/release_0_44
While here, move diffutils from runtime_deps to deps. This is unlikely to matter in practice, but in principle it's the right thing, and it might matter if static analysis or other build tools (-Xlint:all?) went digging into the deps of Truth at compile time. Such problems (albeit when the dependency's API is publicly visible through the using library) are what prompted the creation of java_import#deps (internal Google bug 23781162). For other problems (that might also not apply here), see google/guava#2721