fix: Depend on upstream jna instead of the bundled one #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blorente
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
the
awaiting-review
blorente
force-pushed
the
blorente/jna
branch
from
d57509c
to
2f613d5
Compare
tpasternak
reviewed
Oct 26, 2023
| # so it fails on certain setups. | ||
| jvm_maven_import_external( | ||
| name = "jna", | ||
| artifact = "net.java.dev.jna:jna:5.13.0", |
There was a problem hiding this comment.
@mai93 it's a new dependency added to this project. Can we ask security team whether it's ok to do so? No other issues apart from this one
mai93
approved these changes
Oct 30, 2023
github-actions
bot
removed
the
awaiting-review
blorente
pushed a commit
to blorente/intellij
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Discovered while trying to set up CI for our internal mirror of the plugin.
Description of this change
We test cross-platform (from mac arm to linux x86, for instance). Most of the tests complained that they couldn't find the JNA library. As far as I can tell, we just rely on the JNA that comes bundled with the plugin SDK. However, that implicit dependency doesn't handle Bazel's platform definition.
Therefore, we add a dependency to proper
jnaupstream to be able to run the tests from any combination of platforms.