Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Depend on upstream jna instead of the bundled one #5529

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: Depend on upstream jna instead of the bundled one #5529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,6 +858,16 @@ jvm_maven_import_external(
server_urls = ["https://repo1.maven.org/maven2"],
)

# Usually, we'd get this from the JetBrains SDK, but the bundled one not aware of Bazel platforms,
# so it fails on certain setups.
jvm_maven_import_external(
name = "jna",
artifact = "net.java.dev.jna:jna:5.13.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mai93 it's a new dependency added to this project. Can we ask security team whether it's ok to do so? No other issues apart from this one

artifact_sha256 = "66d4f819a062a51a1d5627bffc23fac55d1677f0e0a1feba144aabdd670a64bb",
licenses = ["notice"], # Apache 2.0
server_urls = ["https://repo1.maven.org/maven2"],
)

# io_grpc_grpc_java dependencies
load("@io_grpc_grpc_java//:repositories.bzl", "IO_GRPC_GRPC_JAVA_ARTIFACTS", "IO_GRPC_GRPC_JAVA_OVERRIDE_TARGETS", "grpc_java_repositories")

Expand Down
3 changes: 3 additions & 0 deletions testing/test_defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ def intellij_integration_test_suite(
deps = list(deps)
deps.extend([
"//testing:lib",
# Usually, we'd get this from the JetBrains SDK, but the bundled one not aware of Bazel platforms,
# so it fails on certain setups.
"@jna",
])
runtime_deps = list(runtime_deps)
runtime_deps.extend([
Expand Down
Loading