Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote_execution.pb.go does not take over comment from remote_execution.proto #107

Closed
atetubou opened this issue Nov 26, 2019 · 1 comment · Fixed by #161
Closed

remote_execution.pb.go does not take over comment from remote_execution.proto #107

atetubou opened this issue Nov 26, 2019 · 1 comment · Fixed by #161

Comments

@atetubou
Copy link
Contributor

If remote_execution.pb.go takes over comment from remote_execution.proto, godoc becomes more useful.
@mostynb
Copy link
Contributor

mostynb commented Nov 26, 2019

I think this is a limitation of protoc-gen-go:
golang/protobuf#666

@atetubou atetubou mentioned this issue Aug 1, 2020
Merged
santigl pushed a commit to santigl/remote-apis that referenced this issue Aug 26, 2020
Removing output directories before downloading. (bazelbuild#107)
af4eb24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include comments in generated *.pb.go for godoc atetubou/remote-apis
2 participants
@atetubou @mostynb