Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include comments in generated *.pb.go for godoc #161

Merged
merged 2 commits into from
Aug 12, 2020
Merged

include comments in generated *.pb.go for godoc #161

merged 2 commits into from
Aug 12, 2020

Conversation

atetubou
Copy link
Contributor

@atetubou atetubou commented Aug 1, 2020 •
edited
Loading

It is very useful if godoc includes comments propagated from proto files.

For that, this PR uses bazel's experimental flag introduced in bazelbuild/bazel#10925

Fix #107

@googlebot googlebot added the cla: yes Pull requests whose authors are covered by a CLA with Google. label Aug 1, 2020
@atetubou
Copy link
Contributor Author

atetubou commented Aug 7, 2020

@EricBurnett could you review this?

mostynb
mostynb reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@mostynb mostynb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty nice. (Note that it will need to be rebased on the tip of master and re-run.)

@atetubou atetubou force-pushed the include_source_info branch from f1a0100 to 779b758 Compare August 11, 2020 11:22
mostynb
mostynb approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@mostynb mostynb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would save me a lot of tab-hunting in my browser.

@atetubou
git squash commit for include_source_info.
823702b 
bf611551719a287c272cfe99a2fa245615f81fc5
git squash commit for include_source_info.

e8eb2a4
add bazelrc

f1a0100
include source info

d6cd257869a11e016c807a81fc41ddf4daec0c60
empty
@atetubou
Copy link
Contributor Author

@sstriker could you merge this?

@mostynb
Copy link
Contributor

mostynb commented Aug 12, 2020

This needs to be re-generated, since another commit (991ea41) landed.

Filed a feature request yesterday to make the generation automatic: #162.

@atetubou atetubou force-pushed the include_source_info branch from 779b758 to d1ab13d Compare August 12, 2020 09:35
@atetubou
Copy link
Contributor Author

Ah, I see. Thanks.

I updated.

@sstriker
Copy link
Collaborator

Ah, I see. Thanks.

I updated.

Thanks!

@sstriker sstriker merged commit 5a7b1a4 into bazelbuild:master Aug 12, 2020
@atetubou atetubou deleted the include_source_info branch August 12, 2020 14:14
@atetubou atetubou mentioned this pull request Sep 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostynb mostynb mostynb approved these changes

@sstriker sstriker sstriker approved these changes

@agoulti agoulti Awaiting requested review from agoulti

@bergsieker bergsieker Awaiting requested review from bergsieker

@buchgr buchgr Awaiting requested review from buchgr

@ola-rozenfeld ola-rozenfeld Awaiting requested review from ola-rozenfeld

Assignees
No one assigned
Labels
cla: yes Pull requests whose authors are covered by a CLA with Google.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remote_execution.pb.go does not take over comment from remote_execution.proto
4 participants
@atetubou @mostynb @sstriker @googlebot