Skip to content

Commit

Permalink
Add go_default_library alias for gomock targets (#3155)
Browse files Browse the repository at this point in the history
Sets `go_naming_convention` to `import_alias` for gomock, as per the other
Go dependencies. This means users with `go_naming_convention` set to
`go_default_library` do not have to make adjustments to
Gazelle generated files or override the dependency.

Fixes #3154
  • Loading branch information
nickgooding authored May 16, 2022
1 parent 498d6ce commit 02c832b
Show file tree
Hide file tree
Showing 2 changed files with 363 additions and 93 deletions.
4 changes: 2 additions & 2 deletions go/private/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -264,13 +264,13 @@ def go_rules_dependencies():
_maybe(
http_archive,
name = "com_github_golang_mock",
# v1.6.0, latest as of 2022-05-09
# v1.6.0, latest as of 2022-05-13
urls = [
"https://mirror.bazel.build/github.com/golang/mock/archive/v1.6.0.zip",
"https://github.com/golang/mock/archive/v1.6.0.zip",
],
patches = [
# releaser:patch-cmd gazelle -repo_root . -go_prefix github.com/golang/mock
# releaser:patch-cmd gazelle -repo_root . -go_prefix github.com/golang/mock -go_naming_convention import_alias
Label("//third_party:com_github_golang_mock-gazelle.patch"),
],
patch_args = ["-p1"],
Expand Down
Loading

0 comments on commit 02c832b

Please sign in to comment.