-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gomock missing go_default_library
targets
#3154
Comments
Sets `go_naming_convention` to `import_alias` for gomock, as per the other Go dependencies. This means users with `go_naming_convention` set to `go_default_library` do not have to make adjustments to Gazelle generated files or override the dependency. Fixes bazelbuild#3154
How can I reproduce the issue? |
To reproduce the issue, have a workspace using the This repo contains a very minimal reproduction: https://github.com/nickgooding/rules_go-3154-repro |
Sets `go_naming_convention` to `import_alias` for gomock, as per the other Go dependencies. This means users with `go_naming_convention` set to `go_default_library` do not have to make adjustments to Gazelle generated files or override the dependency. Fixes #3154
What version of rules_go are you using?
v0.32.0
What version of gazelle are you using?
v0.25.0
What version of Bazel are you using?
v5.1.1
Does this issue reproduce with the latest releases of all the above?
Yes
What operating system and processor architecture are you using?
Mac OS 12.3, x86_64-apple-darwin21.1.0
Any other potentially useful information about your toolchain?
N/A
What did you do?
Tried to build
go_*
targets that depend ongo_default_library
targets in@com_github_golang_mock
after upgrading to rules_go v0.32.0What did you expect to see?
Build would work successfully
What did you see instead?
Builds failed with this error:
Workaround
Adding the following in our workspace and rerunning Gazelle resolved the issue (even though it isn't actually used in lieu of the dependency of rules_go)
The text was updated successfully, but these errors were encountered: