Go package driver doesn't work with Go 1.18

[linzhp]

Current package driver calls builder stdliblist to get information for std libraries. stdliblist calls go list:

rules_go/go/tools/builders/stdliblist.go

Lines 148 to 149 in e9a7054

	// stdliblist runs `go list -json` on the standard library and saves it to a file.
	func stdliblist(args []string) error {

This caused two problems:

1. essentially, std libraries are compiled twice, one by rules_go and one by go list
2. when stdliblist calls go list, it is in Bazel's sandbox, where all Go files of std libraries are symlinks. One of the Go files in 1.18 embeds a binary file, which would break when the binary file is a symlink, leading to errors like:

ERROR: /private/var/tmp/_bazel_zplin/db67431f618bf23018777556a2edc2eb/external/io_bazel_rules_go/BUILD.bazel:44:7: GoStdlibList external/io_bazel_rules_go/stdlib_/stdlib.pkg.json failed: (Exit 1): builder failed: error executing command 
  (cd /private/var/tmp/_bazel_zplin/db67431f618bf23018777556a2edc2eb/sandbox/darwin-sandbox/7496/execroot/__main__ && \
  exec env - \
    APPLE_SDK_PLATFORM=MacOSX \
    APPLE_SDK_VERSION_OVERRIDE=12.1 \
    CGO_ENABLED=1 \
    GOARCH=arm64 \
    GOOS=darwin \
    GOPATH='' \
    GOROOT=external/go_sdk \
    GOROOT_FINAL=GOROOT \
    PATH=external/local_config_cc:/bin:/usr/bin \
    XCODE_VERSION_OVERRIDE=13.2.1.13C100 \
    ZERO_AR_DATE=1 \
  bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/go_sdk/builder stdliblist -sdk external/go_sdk -installsuffix darwin_arm64 -out bazel-out/darwin_arm64-fastbuild/bin/external/io_bazel_rules_go/stdlib_/stdlib.pkg.json)
# Configuration: 3082a7bf331eaf230f27e04497eaecbe1891da6c723270a0d9c69754da9505e4
# Execution platform: @local_config_platform//:host

Use --sandbox_debug to see verbose messages from the sandbox
external/go_sdk/src/crypto/elliptic/p256_asm.go:24:12: pattern p256_asm_table.bin: cannot embed irregular file p256_asm_table.bin
stdliblist: error running subcommand external/go_sdk/bin/go: exit status 1

What version of rules_go are you using?

0.30

What version of Bazel are you using?

5.0.0

What version of Go are you using?

Go 1.18rc1

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

macOS arm64

Any other potentially useful information about your toolchain?

[bolitt]

+1, I got a very similar bug with go 1.18 (stable, darwin_amd64) + bazel 5.0.0 + rules_go 0.30.

external/go_sdk/src/crypto/elliptic/p256_asm.go:24:12: pattern p256_asm_table.bin: cannot embed irregular file p256_asm_table.bin
bazel-out/host/bin/external/org_golang_x_mobile/cmd/gomobile/gomobile_/gomobile: go build -v -buildmode=c-shared -o=/var/folders/lm/g6r0qpk15dsdklyy9w35dh040000gp/T/gomobile-work-1280566553/android/src/main/jniLibs/arm64-v8a/libgojni.so gobind failed: exit status 1

[abhinav]

@bolitt, try my patch #3083.

[jeongukjae]

Same here. bazel 5.0.0 and rules_go v0.31.0

[esprehn]

@linzhp it looks like the new release bumps the golang version to 1.18.x but this fix didn't land, does that mean auto completion is now broken with the configuration suggested in the README.md?

[linzhp]

Yeah, sorry, @xytan0056 may work on #3083 soon.