-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go_path embedding still failing on go 1.18 #3178
Comments
The line:
|
@mancusi Does this also fail with the other modes ( |
Unfortunately those options don't seem to work for me. I attempted to include the bin file (
|
I'm struggling with the same problem. Did you find a solution to this @mancusi ? |
For some reason that library only builds with the |
I hit this issue as well. I think this is due to this https://go-review.googlesource.com/c/go/+/380475 So go does not like symlink for go:embed files. However, in bazel, the sandbox uses the symlinks to the actual files, thus cause golang tooling to complain. Using local=True works because it's using execroot and does not symlink each individual files. |
What version of rules_go are you using?
What version of gazelle are you using?
0.25
What version of Bazel are you using?
5.1.1
Does this issue reproduce with the latest releases of all the above?
Yes
What operating system and processor architecture are you using?
macOS x86
Any other potentially useful information about your toolchain?
n/a
What did you do?
We have a custom rule which runs easyjson in a custom gopath that fails even while including the fix to #3080.
The main command is:
What did you expect to see?
I'd expect that this passes after the fix here.
What did you see instead?
Files in
external/go_sdk
are being symlinked which is causing go:embed to fail with../../../../../../../../../../../external/go_sdk/src/crypto/elliptic/p256_asm.go:24:12: pattern p256_asm_table.bin: cannot embed irregular file p256_asm_table.bin
The text was updated successfully, but these errors were encountered: