-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release v0.33.0 #3175
Prepare release v0.33.0 #3175
Conversation
Would be nice to get a gazelle release coupled with this. ❤️ |
s/you/your/ |
Will try to fix #3178 for this release. |
Do you want to upgrade x_tools too? It's been while since last upgrade |
I remember you saying something about gazelle having to update x_mod first. Has that been done? |
yeah, but I am wondering whether we can make rules_go not relying on Gazelle's version of x_mod. If that's not possible, maybe we should upgrade x_mod in Gazelle and release a new version of Gazelle? It's been a while since last release. |
That seems difficult - we would probably have to get it with a |
687f149
to
3ed977f
Compare
3ed977f
to
6364ad6
Compare
Confirmed that Gazelle tests pass with rules_go at this PR with the latest commit fixing |
just a small note: we should look into how to de-noise the |
https://github.com/bazelbuild/rules_go/blob/master/go/tools/releaser/upgradedep.go#L539-L559 It seems like we do intended to sanitize the patch file from timestamp, but there is a bug that make it fail? 🤔 |
Release Notes
Breaking changes
Deprecations
Bug Fixes
go_test
targets to fail (compilepkg: fix race when run without sandbox #3145)//go:embed
work withgo_path
(go_path: Support go:embed #3163)gomock
can be used with any Gazelle naming convention (Addgo_default_library
alias for gomock targets #3155)go_library
targets using CGo can now reference unresolved symbols (Fix linker error if go_library with cgo references unresolved symbol #3174)Thanks to all of the contributors!
Compatibility
The minimum required version of Bazel remains at 4.2.1.
Updated dependencies
org_golang_x_sys
,org_golang_x_xerrors
,org_golang_google_genproto
,go_googleapis
to their most recent commit as of 2022-06-05As always, you can use higher versions of rules_go's dependencies by declaring them in WORKSPACE before calling go_rules_dependencies. Lower versions may work but are not supported.
WORKSPACE code
// TBD after release