Add exec constraints to local Java runtime toolchains #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hvadehra Could you also review this? It's a follow-up to #114 and the last part of bazelbuild/bazel#18262 that affects rules_java. |
Fixes incorrect behavior in cross-platform build situations where a local Java runtime would end up in the runfiles of a `java_binary` target built for a platform on which it can't be executed. Work towards https://github.com/bazelbuild/bazel/issues#18265 Split off from bazelbuild/bazel#18262
fmeum
force-pushed
the
17085-exec-constraints
branch
from
cb0ab8e
to
34a4dee
Compare
hvadehra
approved these changes
Aug 7, 2023
|
Yeah, there was an issue with the import, I'm trying to get it to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect behavior in cross-platform build situations where a local Java runtime would end up in the runfiles of a
java_binarytarget built for a platform on which it can't be executed.Work towards https://github.com/bazelbuild/bazel/issues#18265
Split off from bazelbuild/bazel#18262