Obtain bootstrap class path from dedicated runtime toolchain type #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2023
fmeum
force-pushed
the
17085-bootstrap-toolchain
branch
from
cb6dfa4
to
46950bb
Compare
|
@hvadehra Could you review this? It is based on bazelbuild/bazel#18841. |
cushon
previously approved these changes
Jul 5, 2023
hvadehra
previously approved these changes
Jul 5, 2023
fmeum
force-pushed
the
17085-bootstrap-toolchain
branch
from
7f94f77
to
58834b4
Compare
|
@hvadehra @cushon Friendly ping. I pushed a commit to fix CI after the merge of bazelbuild/bazel@8715e9a. Let me know whether you would want me to handle this differently. |
cushon
previously approved these changes
Jul 31, 2023
fmeum
added a commit
to fmeum/rules_java
that referenced
this pull request
Jul 31, 2023
Since bazelbuild#114, rules_java requires a version of Bazel that contains bazelbuild/bazel@8715e9a
hvadehra
previously approved these changes
Aug 1, 2023
fmeum
force-pushed
the
17085-bootstrap-toolchain
branch
from
f26cfa6
to
6b04a31
Compare
|
Had to push another commit to fix a breakage that CI didn't catch: I forgot to add the Do you see a way to have CI catch such issues, for example by including a pipeline that runs Bazel@HEAD with an CC @meteorcloudy in case you have an idea |
|
I do feel the test coverage for rules_java is quite limited, I think we can:
I would suggest to look into |
This decouples the concepts of a Java runtime used to run on the target platform from the Java runtime that provides the bootstrap class path used during compilation. The former needs constraints on the target platform, whereas the latter should not have any constraints on the target platform to allow for cross-compilation to target platforms for which a JDK runtime is not available (e.g. Android). Work towards #17085 Work towards bazelbuild#64 Split off from #18262
hvadehra
force-pushed
the
17085-bootstrap-toolchain
branch
from
6b04a31
to
0294790
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
BEGIN_PUBLIC Copybara import of the project: -- cb82ccb by Fabian Meumertzheim <fabian@meumertzhe.im>: Obtain bootstrap class path from dedicated runtime toolchain type This decouples the concepts of a Java runtime used to run on the target platform from the Java runtime that provides the bootstrap class path used during compilation. The former needs constraints on the target platform, whereas the latter should not have any constraints on the target platform to allow for cross-compilation to target platforms for which a JDK runtime is not available (e.g. Android). Work towards #17085 Work towards #64 Split off from #18262 -- ab3c792 by Fabian Meumertzheim <fabian@meumertzhe.im>: Register toolchains in MODULE.bazel -- f2218a4 by Fabian Meumertzheim <fabian@meumertzhe.im>: Update Bazel to 7.0.0-pre.20230710.5 -- 0294790 by Fabian Meumertzheim <fabian@meumertzhe.im>: Add missing WORKSPACE `register_toolchains` calls END_PUBLIC COPYBARA_INTEGRATE_REVIEW=#114 from fmeum:17085-bootstrap-toolchain 0294790 PiperOrigin-RevId: 554446834 Change-Id: I961944be5bfe461528e94c85247f6c36236a561d
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
*** Reason for rollback *** `bazel_compatibility` does not support pre-release versions We can re-introduce this once bazelbuild/bazel#19189 is fixed *** Original change description *** Copybara Merge: #123 BEGIN_PUBLIC Copybara import of the project: -- 3de49c8 by Fabian Meumertzheim <fabian@meumertzhe.im>: Mark rules_java as compatible with Bazel >= 7.0.0-pre.20230710.5 Since #114, rules_java requires a version of Bazel that contains bazelbuild/bazel@8715e9a END_PUBLIC *** PiperOrigin-RevId: 554463780 Change-Id: Ifdbaeb60bce59fdad3bfde8b343ed870d792eba7
|
@hvadehra I think so, thanks! |
|
@hvadehra Could you create a release that I can then update Bazel to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the concepts of a Java runtime used to run on the target platform from the Java runtime that provides the bootstrap class path used during compilation.
The former needs constraints on the target platform, whereas the latter should not have any constraints on the target platform to allow for cross-compilation to target platforms for which a JDK runtime is not available (e.g. Android).
Work towards bazelbuild/bazel#17085
Work towards #64
Split off from bazelbuild/bazel#18262