Remove unnecessary Java runtime dependencies #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bencodes Could you take a look? This is needed to finish my work bazelbuild/bazel#18262 with the aim of removing a lot of footguns from Java cross-compilation. Edit: Didn't see the auto-assigned reviewers before I submitted this comment, if any other maintainer wants to take a look, that is of course appreciated as well. |
|
I learned that |
`kt_jvm_library` no longer depends on a Java runtime for the target platform, which ensures that cross-platform builds targeting platforms without standalone Java runtimes (e.g. Android) can succeed without hacks (currently, Bazel's local_jdk is marked as compatible with any target platform, but that will change in the future).
nkoroste
added a commit
to nkoroste/rules_kotlin
that referenced
this pull request
Sep 15, 2023
…idanceKotlin_upstream * upstream/master: Move the KSP and compiler target definitions into rules_kotlin (bazelbuild#1014) Avoid running java_common#compile against KSP generated outputs (bazelbuild#990) Update kt_java_stub_template to 6.2.1 (bazelbuild#992) Disable strict deps for Android example (bazelbuild#1013) Group the all_tests jobs together in presubmit.yml (bazelbuild#1008) Add rules_java 6.4.0 (bazelbuild#1010) Update Bazel to 6.3.2 (bazelbuild#1007) Update rules_jvm_external to 5.3 (bazelbuild#1009) Migrate usages of deprecated `JavaInfo` fields (bazelbuild#1005) Remove unnecessary Java runtime dependencies (bazelbuild#1000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kt_jvm_libraryno longer depends on a Java runtime for the target platform, which ensures that cross-platform builds targeting platforms without standalone Java runtimes (e.g. Android) can succeed without hacks (currently, Bazel's local_jdk is marked as compatible with any target platform, but that will change in the future).Work towards bazelbuild/bazel#17085