Migrate usages of deprecated JavaInfo fields
#1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transitive_deps was an alias for transitive_compile_time_jars transitive_runtime_deps was an alias for transitive_runtime_jars The fields were deprecated in 2021, and are dropped in Bazel@HEAD Fixes bazelbuild#1003
hvadehra
requested review from
cgruber,
timpeut and
restingbull
as code owners
hvadehra
changed the title
JavaInfo fieldsJavaInfo fields
Bencodes
approved these changes
Aug 11, 2023
|
Hi @Bencodes, There are many Downstream projects which are using rules_kotlin are failing with Bazel@HEAD. Can you please initiate a release. 1. bazelbuild/examples#303 2.protocolbuffers/protobuf#13830. 3. bazel-contrib/rules_jvm_external#946. 4.google/flogger#361 |
|
@Bencodes Can you please help creating a new release for rules_kotlin so that we can fix other dependent projects? |
@meteorcloudy a 1.8.1 release has been published with the fixes for the deprecated provider methods included. |
|
Awesome, thank you! |
|
Sure, Thank you!! |
nkoroste
added a commit
to nkoroste/rules_kotlin
that referenced
this pull request
Sep 15, 2023
…idanceKotlin_upstream * upstream/master: Move the KSP and compiler target definitions into rules_kotlin (bazelbuild#1014) Avoid running java_common#compile against KSP generated outputs (bazelbuild#990) Update kt_java_stub_template to 6.2.1 (bazelbuild#992) Disable strict deps for Android example (bazelbuild#1013) Group the all_tests jobs together in presubmit.yml (bazelbuild#1008) Add rules_java 6.4.0 (bazelbuild#1010) Update Bazel to 6.3.2 (bazelbuild#1007) Update rules_jvm_external to 5.3 (bazelbuild#1009) Migrate usages of deprecated `JavaInfo` fields (bazelbuild#1005) Remove unnecessary Java runtime dependencies (bazelbuild#1000)
jbarr21
pushed a commit
to uber-common/rules_kotlin
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transitive_depswas an alias fortransitive_compile_time_jarstransitive_runtime_depswas an alias fortransitive_runtime_jarsThe fields were deprecated in 2021, and are dropped in Bazel@HEAD
Fixes #1003