jmh normalizes jar timestamps (#396)

* jmh normalizes jar timestamps build_is_identical e2e test spits out differences in md5 * change jar creator to default to normalizing timestamps
bazelbuild · Jan 18, 2018 · 375b34a · 375b34a
1 parent 0b41f54
commit 375b34a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/src/java/io/bazel/rulesscala/jar/JarCreator.java b/src/java/io/bazel/rulesscala/jar/JarCreator.java
@@ -209,7 +209,6 @@ public static void buildJar(String[] args) throws IOException {
       }
     }
     createJar.setCompression(true);
-    createJar.setNormalize(true);
     createJar.execute();
   }
 

diff --git a/src/java/io/bazel/rulesscala/jar/JarHelper.java b/src/java/io/bazel/rulesscala/jar/JarHelper.java
@@ -52,7 +52,7 @@ public class JarHelper {
   protected final String jarFile;
 
   // The properties to describe how to create the Jar
-  protected boolean normalize;
+  protected boolean normalize = true;
   protected int storageMethod = JarEntry.DEFLATED;
   protected boolean verbose = false;
 

diff --git a/test_rules_scala.sh b/test_rules_scala.sh
@@ -26,7 +26,7 @@ echo "$_md5_util"
 }
 
 non_deploy_jar_md5_sum() {
-  find bazel-bin/test -name "*.jar" ! -name "*_deploy.jar" | $(md5_util)
+  find bazel-bin/test -name "*.jar" ! -name "*_deploy.jar" | xargs -n 1 -P 5 $(md5_util) | sort
 }
 
 test_build_is_identical() {