jmh normalizes jar timestamps #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build_is_identical e2e test spits out differences in md5
|
👍 |
|
@johnynek thanks! |
johnynek
approved these changes
Jan 17, 2018
|
only mac builds haven't run due to travis ongoing mac issues, I've run locally on a mac and merging |
jmendiara
added a commit
to jmendiara/rules_scala
that referenced
this pull request
Jun 20, 2018
Issues referenced for building in MAC (bazelbuild#136, bazelbuild#396 and bazelbuild#398) are closed/merged Having the comment `This doesn't currently pass on OS X (see bazelbuild#136 for details)` is not accurate. BTW, I cannot confirm it's true, cause in my env have bazel 0.14 and `test_all.sh` is failing (`bazel test //test/...` is OK)
ittaiz
pushed a commit
that referenced
this pull request
Jun 20, 2018
Issues referenced for building in MAC (#136, #396 and #398) are closed/merged Having the comment `This doesn't currently pass on OS X (see #136 for details)` is not accurate. BTW, I cannot confirm it's true, cause in my env have bazel 0.14 and `test_all.sh` is failing (`bazel test //test/...` is OK)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionally build_is_identical e2e test spits out differences in specific jar md5 files and not only the change in all of them. Actually useful for debugging reproducibility problems