build_is_identical stabilization #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnynek I was worried on how come the jmh problem never surfaced on CI and only locally and I have a theory that it's because |
Closed
|
@johnynek any objections? |
|
no, this is great. Just frustrating that travis behaves so poorly. |
|
Indeed.
They've been having a rough few days with respect to mac builds
…On Fri, 19 Jan 2018 at 22:40 P. Oscar Boykin ***@***.***> wrote:
Merged #398 <#398>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#398 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABUIF17reiJCajLHI5xUoTM04uwZw3byks5tMP2qgaJpZM4Riisx>
.
|
jmendiara
added a commit
to jmendiara/rules_scala
that referenced
this pull request
Jun 20, 2018
Issues referenced for building in MAC (bazelbuild#136, bazelbuild#396 and bazelbuild#398) are closed/merged Having the comment `This doesn't currently pass on OS X (see bazelbuild#136 for details)` is not accurate. BTW, I cannot confirm it's true, cause in my env have bazel 0.14 and `test_all.sh` is failing (`bazel test //test/...` is OK)
ittaiz
pushed a commit
that referenced
this pull request
Jun 20, 2018
Issues referenced for building in MAC (#136, #396 and #398) are closed/merged Having the comment `This doesn't currently pass on OS X (see #136 for details)` is not accurate. BTW, I cannot confirm it's true, cause in my env have bazel 0.14 and `test_all.sh` is failing (`bazel test //test/...` is OK)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.