fix: remove location.search calls from SMP plugin (#730)

* fix: prevents location.search calls from plugin * chore: bumps version to 1.4.5
bbc · Mar 11, 2024 · aed18cc · aed18cc
1 parent 628c0d6
commit aed18cc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bbc/storyplayer",
-  "version": "1.4.4",
+  "version": "1.4.5",
   "description": "StoryPlayer - reference player for BBC Research & Development's object-based media schema (https://www.npmjs.com/package/@bbc/object-based-media-schema)",
   "main": "./dist/storyplayer.js",
   "module": "./dist/storyplayer.js",

diff --git a/src/gui/Player.ts b/src/gui/Player.ts
@@ -145,9 +145,8 @@ class Player extends EventEmitter {
 
         this.useExternalTransport = () => {
             // eslint-disable-next-line no-restricted-globals
-            const useExternal =
-                new URLSearchParams(parent.location.search).getAll("noUi")
-                    .length > 0 || this._controller.options?.noUi
+            const useExternal = 
+                getSetting("noUi") === "true" || this._controller.options?.noUi
             if (useExternal === undefined) return false
             return useExternal
         }

diff --git a/src/utils.ts b/src/utils.ts
@@ -87,6 +87,7 @@ export const getCurrentUrl = () => {
     return window.location.href
 }
 export const getVariableOverrides = () => {
+    if (inSMPWrapper) return [];
     const varNames = new URLSearchParams(window.location.search).getAll(
         "varName",
     )