fix: remove location.search calls from SMP plugin #730
Conversation
andy-brown
changed the title
| new URLSearchParams(parent.location.search).getAll("noUi") | ||
| .length > 0 || this._controller.options?.noUi | ||
| const useExternal = | ||
| getSetting("noUi") === "true" || this._controller.options?.noUi |
There was a problem hiding this comment.
In the storyplayer harness plugin (https://github.com/bbc/rd-ux-storyplayer-harness/blob/0fba3592def9540b835efe2ef0a2535af9f40b0f/plugin/plugin.js#L31C1-L31C84), to get the URL of the enclosing page we use:
const pageUrl = new URL(pluginUtils.playerInterface.settings.embedPageURL);
Not sure if that makes any difference to how we do things
There was a problem hiding this comment.
Yes, but this is meaningless outside the plugin.
There was a problem hiding this comment.
Finally managed to get this tested. Tested using the SMP Plugin in the Harness with Storyplayer version 1.4.4 (main) and 1.4.5 (this PR) to play Click100.
Repeated the error in Chrome on 1.4.4:
DOMException: Failed to read a named property 'search' from 'Location': Blocked a frame with origin "https: //emp.bbcconne smp-js:71 ctedstudio.co.uk" from accessing a cross-origin frame.
No error in 1.4.5. Playback all seems correct.
Details
Prevents SMP plugin from throwing a console error in Chrome, since window.location cannot be used within iframe.
I've only been able to test that the
noUi=truequery parameter still works, as I can't bring up a local SPH instance with a local SP linked.Ticket / issue URL
Ticket / issue URL: https://jira.dev.bbc.co.uk/browse/PRODTOOLS-3980
PR Checks
(tick as appropriate)