Use left/right arrow keys for changing to next/prev gallery slide #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a version command
Fix bbc#298 - use the latest version of ImageMagick with Docker
Enforce a user configured directory for capture
Allow newer nokogiris
Improvements
a) casperjs isn't necessarily a dependency. Some people only use PhantomJS b) this is causing issues when we try to upgrade to phantomjs 2.x, which requires casperjs beta 1.1. By listing casperjs as a dependency inside the Wraith gemspec, we're installing the default version of casperjs available to Rubygems, and this becomes the casperjs executable even if we've installed casperjs through something like brew. Consequently, we're stuck with an outdated version of casperjs and that prevents us from moving to phantomjs 2. We should trust developers to sort out their own phantom/casper dependencies/configurations.
add casperjs as a developer dependency
Updated Dockerfile to install the new phantomjs and casperjs
Fix "undefined local variable or method `wraith'"
|
Thanks @vfonic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.