Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaybeStruct serialization constructor call throws exception in none case #81

Closed
stefan-lindegger opened this issue Apr 27, 2020 · 0 comments · Fixed by #83
Closed

MaybeStruct serialization constructor call throws exception in none case #81

stefan-lindegger opened this issue Apr 27, 2020 · 0 comments · Fixed by #83
Labels
Bug Something isn't working
Milestone
3.1.0

Comments

@stefan-lindegger
Copy link
Member

stefan-lindegger commented Apr 27, 2020 •
edited
Loading

Bug in line:

BBT.Maybe/src/BBT.MaybePattern/MaybeStruct.cs

Line 37 in e522491

this.value = MaybeUtils.GetDeserializedValue<T>(info, nameof(this.value));

SerializationInfo value is casted into T instead of T?.
@stefan-lindegger stefan-lindegger added the Bug Something isn't working label Apr 27, 2020
stefan-lindegger pushed a commit to stefan-lindegger/BBT.Maybe that referenced this issue Apr 28, 2020
(bbtsoftwareGH-81) fixed issue with deserialization of MaybeStruct no…
df667d9 
…ne case.
@stefan-lindegger stefan-lindegger mentioned this issue Apr 28, 2020
Merged
stefan-lindegger pushed a commit to stefan-lindegger/BBT.Maybe that referenced this issue Apr 28, 2020
(bbtsoftwareGH-81) fixed issue with deserialization of MaybeStruct no…
0a4a5cc 
…ne case.
stefan-lindegger pushed a commit to stefan-lindegger/BBT.Maybe that referenced this issue Apr 28, 2020
(bbtsoftwareGH-81) fixed issue with deserialization of MaybeStruct no…
4afaf4f 
…ne case.
@pascalberger pascalberger added this to the 3.1.0 milestone Apr 28, 2020
stefan-lindegger pushed a commit to stefan-lindegger/BBT.Maybe that referenced this issue Apr 29, 2020
(bbtsoftwareGH-81) fixed issue with deserialization of MaybeStruct no…
753255d 
…ne case.
stefan-lindegger added a commit that referenced this issue Apr 29, 2020
@stefan-lindegger
Merge pull request #83 from stefan-lindegger/feature/GH-81
005393c 
(GH-81) Fixed issue with deserialization of MaybeStruct none case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

(GH-81) Fixed issue with deserialization of MaybeStruct none case stefan-lindegger/BBT.Maybe
2 participants
@pascalberger @stefan-lindegger