Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-81) Fixed issue with deserialization of MaybeStruct none case #83

Merged

Conversation

stefan-lindegger
Copy link
Member

Fixes #81.

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #83 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          127       127           
  Branches        16        16           
=========================================
  Hits           127       127           
Impacted Files Coverage Δ
src/BBT.MaybePattern/MaybeStruct.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94569e...753255d. Read the comment docs.

@pascalberger pascalberger changed the title (GH-81) fixed issue with deserialization of MaybeStruct none case. (GH-81) Fixed issue with deserialization of MaybeStruct none case Apr 28, 2020
Copy link
Collaborator

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments regarding disposing in testing code. Otherwise LGTM

src/BBT.MaybePattern.Tests/MaybeIntTests.cs Outdated Show resolved Hide resolved
src/BBT.MaybePattern.Tests/MaybeIntTests.cs Outdated Show resolved Hide resolved
src/BBT.MaybePattern.Tests/MaybeStructIntTests.cs Outdated Show resolved Hide resolved
src/BBT.MaybePattern.Tests/MaybeStructIntTests.cs Outdated Show resolved Hide resolved
src/BBT.MaybePattern.Tests/TestUtils.cs Show resolved Hide resolved
@stefan-lindegger stefan-lindegger deleted the feature/GH-81 branch April 29, 2020 05:16
@stefan-lindegger stefan-lindegger restored the feature/GH-81 branch April 29, 2020 05:21
@stefan-lindegger stefan-lindegger merged commit 005393c into bbtsoftware:develop Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

MaybeStruct serialization constructor call throws exception in none case
2 participants