15601 Legal Name changes #575

severinbeauvais · 2023-10-04T21:00:57Z

Issue #: bcgov/entity#15601

Description of changes:

Commit 1:

app version = 5.6.0

Commit 2:

updated Legal API URL (temporary)
save operating name from business info
added operating name to state
added alternate names array to business inteface
added operating name store getter and setter
initialized operating name in state

Commit 3:

added temp API URL to example env file
added temp API URL to vaults env file
fixed misc code issues
changed DocumentMixin hook from created() to beforeCreate() to avoid type conflict
updated getBusinessLegalName to return operating name for firms

Commits 4-5-6:

updated EntityInfo unit tests
added ids to some AssociationDetails elements
added AssociationDetails unit tests
updated App unit tests

Commits 7-8-9-10:

~~deleted obsolete nginx config~~
~~commented out invalid comment in Dockerfile~~
updated firebase config to allow connecting to Legal API temp URL
renamed jest-wrapper-factory -> vitest-wrapper-factory

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

- save operating name from business info - added operating name to state - added alternate names array to business inteface - added operating name store getter and setter - initialized operating name in state

severinbeauvais · 2023-10-04T21:44:24Z

src/App.vue

@@ -361,7 +362,7 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi
  readonly window = window

  /** The Update Current JS Date timer id. */
-  private updateCurrentJsDateId = 0
+  private updateCurrentJsDateId = null as any // NodeJS.Timeout


Node complains that this variable is not a number (though I think it is a number in the browser) so I just typed it as any.

In browser:

severinbeauvais · 2023-10-04T21:44:41Z

src/App.vue

@@ -810,7 +811,7 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi
    // NB: will throw if API error
    let draftFiling = await LegalServices.fetchFirstTask(businessId)

-    this.setFilingType(draftFiling.header.name)
+    this.setFilingType(draftFiling.header.name as FilingTypes)


Fixed warning because name is a string.

severinbeauvais · 2023-10-04T21:47:49Z

src/components/Dissolution/AssociationDetails.vue

@@ -194,12 +194,12 @@ export default class AssociationDetails extends Mixins(CommonMixin, DateMixin) {

  /** The entity name. */
  get entityName (): string {
-    return this.getBusinessLegalName || GetCorpNumberedDescription(this.getEntityType)
+    return this.getBusinessLegalName || GetCorpNumberedDescription(this.getEntityType as any)


There's a mismatch between CorpTypeCd in GetCorpNumberedDescription() and CorpTypeCd from getEntityType that I couldn't figure out quickly so I just typed it as any.

severinbeauvais · 2023-10-04T21:52:04Z

src/resources/BreadCrumbResource.ts

@@ -10,22 +9,18 @@ const store = useStore()

 /** Returns legal name. */
 function getLegalName (): string {
-  const getFilingType: FilingTypes = store.getFilingType
-  const getBusinessLegalName: string = store.getBusinessLegalName
-  const getNameRequestApprovedName: string = store.getNameRequestApprovedName


getFilingType was only used once so I moved it there.

getBusinessLegalName was only needed in some cases so I moved it there.

getNameRequestApprovedName was only needed in some cases so I moved it there.

^^ Although it looked nice to assign variables ahead of time, in all cases some variables weren't used, so I simplified this.

severinbeauvais · 2023-10-04T21:56:21Z

src/utils/FetchConfig.ts

-  const legalApiUrl: string = (import.meta.env.VUE_APP_LEGAL_API_URL + import.meta.env.VUE_APP_LEGAL_API_VERSION_2 + '/')
+  const legalApiUrl: string = (
+    import.meta.env.VUE_APP_LEGAL_API_URL + import.meta.env.VUE_APP_LEGAL_API_VERSION_2 + '/'
+  )


Line was too long.

We probably need to fix lint at some point to make it not run the project if there was a lint error. I remember I created a ticket for that back when I did the Vite work but no idea when will we be able to get to that ticket.

I think all we need to do is change lint warnings to errors. But this is a problem for another day. (Hope you agree!)

Oh yes, for sure Sev! I also found the ticket: bcgov/entity#17320

A problem for another day 🙌

severinbeauvais · 2023-10-04T21:57:40Z

src/utils/FetchConfig.ts

-    (import.meta.env.VUE_APP_REGISTRIES_SEARCH_API_URL + import.meta.env.VUE_APP_REGISTRIES_SEARCH_API_VERSION + '/')
+  const registriesSearchApiUrl: string = (
+    import.meta.env.VUE_APP_REGISTRIES_SEARCH_API_URL + import.meta.env.VUE_APP_REGISTRIES_SEARCH_API_VERSION + '/'
+  )


Parentheses not used consistently.

severinbeauvais · 2023-10-06T19:14:16Z

.env.example

-VUE_APP_LEGAL_API_URL="https://legal-api-dev.apps.silver.devops.gov.bc.ca"
+# for Legal Name feature branch only:
+VUE_APP_LEGAL_API_URL="https://business-api-dy4loprnwa-nn.a.run.app"
+#VUE_APP_LEGAL_API_URL="https://legal-api-dev.apps.silver.devops.gov.bc.ca"


This will need to be updated when merging to main branch.

@argush3 ^^

... Whatever we end up doing for the new Legal (Name) API URL ...

severinbeauvais · 2023-10-06T19:14:34Z

devops/vaults.env

-VUE_APP_LEGAL_API_URL="op://API/$APP_ENV/legal-api/LEGAL_API_URL"
+# for Legal Name feature branch only:
+VUE_APP_LEGAL_API_URL="op://API/$APP_ENV/legal-api/LEGAL_NAME_API_URL"
+#VUE_APP_LEGAL_API_URL="op://API/$APP_ENV/legal-api/LEGAL_API_URL"


This will need to be updated when merging to main branch.

@argush3 ^^

... Whatever we end up doing for the new Legal (Name) API URL ...

- added temp API URL to vaults env file - fixed misc code issues - changed DocumentMixin hook from created() to beforeCreate() to avoid type conflict - updated getBusinessLegalName to return operating name for firms

- added AssociationDetails unit tests

severinbeauvais · 2023-10-06T22:19:40Z

tests/unit/App.spec.ts

+
+describe('Breadcrumbs for firms', () => {
+  it('computes breadcrumbs correctly for a SP registration', () => {
+    const wrapper = shallowWrapperFactory(


I decided to shallow-mount App.vue (meaning the Breadcrumb sub-component is stubbed, not fully rendered) and I check the breadcrumbs computed instead.

nginx.conf

- updated firebase config to allow connecting to Legal API temp URL

severinbeauvais · 2023-10-06T22:53:12Z

firebase.json

@@ -20,7 +20,7 @@
            { "key" : "X-XSS-Protection", "value" : "1; mode=block" },
            {
              "key": "Content-Security-Policy",
-              "value": "default-src 'self'; frame-src 'self' *.gov.bc.ca *.hotjar.com *.googleapis.com https://*.nr-data.net https://*.newrelic.com https://*.cac1.pure.cloud; script-src 'self' 'unsafe-eval' 'unsafe-inline' *.gov.bc.ca *.hotjar.com *.googleapis.com https://*.nr-data.net https://*.newrelic.com https://*.cac1.pure.cloud; style-src 'self' 'unsafe-inline' *.cloudflare.com *.googleapis.com; font-src 'self' *.gov.bc.ca *.hotjar.com *.cloudflare.com *.googleapis.com *.gstatic.com *.jsdelivr.net; img-src 'self' data: *.hotjar.com https://*.cac1.pure.cloud; connect-src 'self' *.gov.bc.ca *.launchdarkly.com *.hotjar.com *.postescanada-canadapost.ca *.sentry.io *.apigee.net wss://*.hotjar.com *.hotjar.io https://*.nr-data.net https://shyrka-prod-cac1.s3.ca-central-1.amazonaws.com https://*.newrelic.com https://*.cac1.pure.cloud wss://*.cac1.pure.cloud; manifest-src 'self'; media-src 'self' https://*.cac1.pure.cloud; object-src 'self' https://*.cac1.pure.cloud; child-src 'self' https://*.cac1.pure.cloud;"
+              "value": "default-src 'self'; frame-src 'self' *.gov.bc.ca *.hotjar.com *.googleapis.com https://*.nr-data.net https://*.newrelic.com https://*.cac1.pure.cloud; script-src 'self' 'unsafe-eval' 'unsafe-inline' *.gov.bc.ca *.hotjar.com *.googleapis.com https://*.nr-data.net https://*.newrelic.com https://*.cac1.pure.cloud; style-src 'self' 'unsafe-inline' *.cloudflare.com *.googleapis.com; font-src 'self' *.gov.bc.ca *.hotjar.com *.cloudflare.com *.googleapis.com *.gstatic.com *.jsdelivr.net; img-src 'self' data: *.hotjar.com https://*.cac1.pure.cloud; connect-src 'self' *.gov.bc.ca *.run.app *.launchdarkly.com *.hotjar.com *.postescanada-canadapost.ca *.sentry.io *.apigee.net wss://*.hotjar.com *.hotjar.io https://*.nr-data.net https://shyrka-prod-cac1.s3.ca-central-1.amazonaws.com https://*.newrelic.com https://*.cac1.pure.cloud wss://*.cac1.pure.cloud; manifest-src 'self'; media-src 'self' https://*.cac1.pure.cloud; object-src 'self' https://*.cac1.pure.cloud; child-src 'self' https://*.cac1.pure.cloud;"


This will need to be updated when merging to main branch.

@argush3 ^^

(Need to remove connect-src *.run.app.)

nginx.conf

src/components/Dissolution/CompleteAffidavit.vue

src/components/Restoration/BusinessName.vue

tests/unit/App.spec.ts

Dockerfile

JazzarKarim

Looks great Sev! 👍

- restored nginx config

severinbeauvais · 2023-10-06T23:26:59Z

/gcbrun

bcregistry-sre · 2023-10-06T23:29:45Z

Temporary Url for review: https://business-create-dev--pr-575-vg2a7q4z.web.app

SB says:

sample GP registration: https://business-create-dev--pr-575-vg2a7q4z.web.app/registration-define-business?id=T8RVmEjm9p&accountid=3040
sample SP dissolution: https://business-create-dev--pr-575-vg2a7q4z.web.app/dissolution-firm?id=FM0554669&accountid=3040

ketaki-deodhar

Looked through all the changes. Looks good!

PaulGarewal

LGTM

jamespaologarcia

Looks good

* - app version = 5.6.0 * - updated Legal API URL (temporary) - save operating name from business info - added operating name to state - added alternate names array to business inteface - added operating name store getter and setter - initialized operating name in state * - added temp API URL to example env file - added temp API URL to vaults env file - fixed misc code issues - changed DocumentMixin hook from created() to beforeCreate() to avoid type conflict - updated getBusinessLegalName to return operating name for firms * - updated EntityInfo unit tests * - added ids to some AssociationDetails elements - added AssociationDetails unit tests * - updated App unit tests * - deleted obsolete nginx config - updated firebase config to allow connecting to Legal API temp URL * - commented out invalid comment in Dockerfil * - renamed jest-wrapper-factory -> vitest-wrapper-factory * - reverted Dockerfile - restored nginx config

severinbeauvais added 2 commits October 4, 2023 10:43

- app version = 5.6.0

4a2b88d

- updated Legal API URL (temporary)

da2b05b

- save operating name from business info - added operating name to state - added alternate names array to business inteface - added operating name store getter and setter - initialized operating name in state

severinbeauvais self-assigned this Oct 4, 2023

severinbeauvais changed the base branch from main to feature-legal-name October 4, 2023 21:01

severinbeauvais force-pushed the 15601 branch from bc69d15 to 8529d9b Compare October 4, 2023 21:42

severinbeauvais commented Oct 4, 2023

View reviewed changes

severinbeauvais requested a review from jamespaologarcia October 5, 2023 17:03

severinbeauvais commented Oct 6, 2023

View reviewed changes

- added temp API URL to example env file

88a2299

- added temp API URL to vaults env file - fixed misc code issues - changed DocumentMixin hook from created() to beforeCreate() to avoid type conflict - updated getBusinessLegalName to return operating name for firms

severinbeauvais force-pushed the 15601 branch from 8529d9b to 88a2299 Compare October 6, 2023 19:36

severinbeauvais added 3 commits October 6, 2023 14:47

- updated EntityInfo unit tests

3902657

- added ids to some AssociationDetails elements

36d0c3f

- added AssociationDetails unit tests

- updated App unit tests

bdf990f

severinbeauvais commented Oct 6, 2023

View reviewed changes

bcgov deleted a comment from bcregistry-sre Oct 6, 2023

severinbeauvais requested review from JazzarKarim, PaulGarewal, ketaki-deodhar and leodube-aot October 6, 2023 22:21

severinbeauvais marked this pull request as ready for review October 6, 2023 22:23

severinbeauvais changed the title ~~15601 Legal Name change~~ 15601 Legal Name changes Oct 6, 2023

severinbeauvais requested a review from argush3 October 6, 2023 22:23

bcgov deleted a comment from bcregistry-sre Oct 6, 2023

severinbeauvais commented Oct 6, 2023

View reviewed changes

nginx.conf Outdated Show resolved Hide resolved

- deleted obsolete nginx config

1ddfe57

- updated firebase config to allow connecting to Legal API temp URL

severinbeauvais force-pushed the 15601 branch from ade1eeb to 1ddfe57 Compare October 6, 2023 22:50

bcgov deleted a comment from bcregistry-sre Oct 6, 2023

severinbeauvais commented Oct 6, 2023

View reviewed changes

nginx.conf Outdated Show resolved Hide resolved

JazzarKarim reviewed Oct 6, 2023

View reviewed changes

src/components/Dissolution/CompleteAffidavit.vue Show resolved Hide resolved

JazzarKarim reviewed Oct 6, 2023

View reviewed changes

src/components/Restoration/BusinessName.vue Show resolved Hide resolved

- commented out invalid comment in Dockerfil

c3d93b7

JazzarKarim reviewed Oct 6, 2023

View reviewed changes

tests/unit/App.spec.ts Outdated Show resolved Hide resolved

- renamed jest-wrapper-factory -> vitest-wrapper-factory

aa02eb9

severinbeauvais commented Oct 6, 2023

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

bcgov deleted a comment from bcregistry-sre Oct 6, 2023

JazzarKarim approved these changes Oct 6, 2023

View reviewed changes

- reverted Dockerfile

1cfc1eb

- restored nginx config

severinbeauvais force-pushed the 15601 branch from 37621eb to 1cfc1eb Compare October 6, 2023 23:24

bcgov deleted a comment from bcregistry-sre Oct 6, 2023

ketaki-deodhar approved these changes Oct 10, 2023

View reviewed changes

PaulGarewal approved these changes Oct 10, 2023

View reviewed changes

argush3 approved these changes Oct 10, 2023

View reviewed changes

severinbeauvais merged commit 4c1dbb5 into bcgov:feature-legal-name Oct 10, 2023
5 checks passed

jamespaologarcia reviewed Oct 10, 2023

View reviewed changes

severinbeauvais mentioned this pull request Oct 13, 2023

15600 display correct name for SP/GP bcgov/business-filings-ui#548

Merged

severinbeauvais mentioned this pull request Oct 30, 2023

15601 Merge Legal Name branch into main branch #579

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

15601 Legal Name changes #575

15601 Legal Name changes #575

severinbeauvais commented Oct 4, 2023 •

edited

Loading

severinbeauvais Oct 4, 2023 •

edited

Loading

severinbeauvais Oct 4, 2023

severinbeauvais Oct 4, 2023

severinbeauvais Oct 4, 2023 •

edited

Loading

severinbeauvais Oct 4, 2023

JazzarKarim Oct 6, 2023

severinbeauvais Oct 6, 2023

JazzarKarim Oct 6, 2023

severinbeauvais Oct 4, 2023

severinbeauvais Oct 6, 2023

severinbeauvais Oct 10, 2023

severinbeauvais Oct 6, 2023

severinbeauvais Oct 10, 2023

severinbeauvais Oct 6, 2023 •

edited

Loading

severinbeauvais Oct 6, 2023

severinbeauvais Oct 10, 2023

JazzarKarim left a comment

severinbeauvais commented Oct 6, 2023

bcregistry-sre commented Oct 6, 2023 •

edited by severinbeauvais

Loading

ketaki-deodhar left a comment

PaulGarewal left a comment

jamespaologarcia left a comment

15601 Legal Name changes #575

15601 Legal Name changes #575

Conversation

severinbeauvais commented Oct 4, 2023 • edited Loading

severinbeauvais Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

severinbeauvais Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

severinbeauvais Oct 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JazzarKarim left a comment

Choose a reason for hiding this comment

severinbeauvais commented Oct 6, 2023

bcregistry-sre commented Oct 6, 2023 • edited by severinbeauvais Loading

ketaki-deodhar left a comment

Choose a reason for hiding this comment

PaulGarewal left a comment

Choose a reason for hiding this comment

jamespaologarcia left a comment

Choose a reason for hiding this comment

severinbeauvais commented Oct 4, 2023 •

edited

Loading

severinbeauvais Oct 4, 2023 •

edited

Loading

severinbeauvais Oct 4, 2023 •

edited

Loading

severinbeauvais Oct 6, 2023 •

edited

Loading

bcregistry-sre commented Oct 6, 2023 •

edited by severinbeauvais

Loading