-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15601 Legal Name changes #575
Changes from 7 commits
4a2b88d
da2b05b
88a2299
3902657
36d0c3f
bdf990f
1ddfe57
c3d93b7
aa02eb9
1cfc1eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,22 @@ | ||
# Base Path Openshift: /businesses/create Firebase: | ||
VUE_APP_PATH="/" | ||
|
||
#vaults Shared | ||
# vaults Shared | ||
VUE_APP_ADDRESS_COMPLETE_KEY="op://canadapost/$APP_ENV/address-key/ADDRESS_COMPLETE_KEY" | ||
|
||
#vaults web-url | ||
# vaults web-url | ||
VUE_APP_REGISTRY_HOME_URL="op://web-url/$APP_ENV/registry/REGISTRY_HOME_URL" | ||
VUE_APP_AUTH_WEB_URL="op://web-url/$APP_ENV/auth-web/AUTH_WEB_URL" | ||
VUE_APP_BUSINESSES_URL="op://web-url/$APP_ENV/business/BUSINESSES_URL" | ||
VUE_APP_DASHBOARD_URL="op://web-url/$APP_ENV/business/DASHBOARD_URL" | ||
VUE_APP_SITEMINDER_LOGOUT_URL="op://web-url/$APP_ENV/siteminder/SITEMINDER_LOGOUT_URL" | ||
|
||
#vaults API | ||
# vaults API | ||
VUE_APP_AUTH_API_URL="op://API/$APP_ENV/auth-api/AUTH_API_URL" | ||
VUE_APP_AUTH_API_VERSION="op://API/$APP_ENV/auth-api/AUTH_API_VERSION" | ||
VUE_APP_LEGAL_API_URL="op://API/$APP_ENV/legal-api/LEGAL_API_URL" | ||
# for Legal Name feature branch only: | ||
VUE_APP_LEGAL_API_URL="op://API/$APP_ENV/legal-api/LEGAL_NAME_API_URL" | ||
#VUE_APP_LEGAL_API_URL="op://API/$APP_ENV/legal-api/LEGAL_API_URL" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will need to be updated when merging to main branch. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @argush3 ^^ ... Whatever we end up doing for the new Legal (Name) API URL ... |
||
VUE_APP_LEGAL_API_VERSION_2="op://API/$APP_ENV/legal-api/LEGAL_API_VERSION_2" | ||
VUE_APP_NAICS_API_URL="op://API/$APP_ENV/naics-api/NAICS_API_URL" | ||
VUE_APP_NAICS_API_VERSION_2="op://API/$APP_ENV/naics-api/NAICS_API_VERSION" | ||
|
@@ -26,22 +28,22 @@ VUE_APP_REGISTRIES_SEARCH_API_URL="op://API/$APP_ENV/registries-search-api/REGIS | |
VUE_APP_REGISTRIES_SEARCH_API_VERSION="op://API/$APP_ENV/registries-search-api/REGISTRIES_SEARCH_API_VERSION" | ||
VUE_APP_REGISTRIES_SEARCH_API_KEY="op://API/$APP_ENV/registries-search-api/REGISTRIES_SEARCH_API_KEY" | ||
|
||
#vaults launchdarkly | ||
# vaults launchdarkly | ||
VUE_APP_BUSINESS_CREATE_LD_CLIENT_ID="op://launchdarkly/$APP_ENV/business-create/BUSINESS_CREATE_LD_CLIENT_ID" | ||
|
||
#vaults keycloak | ||
# vaults keycloak | ||
VUE_APP_KEYCLOAK_AUTH_URL="op://keycloak/$APP_ENV/base/KEYCLOAK_AUTH_BASE_URL" | ||
VUE_APP_KEYCLOAK_REALM="op://keycloak/$APP_ENV/base/KEYCLOAK_REALMNAME" | ||
VUE_APP_KEYCLOAK_CLIENTID="op://keycloak/$APP_ENV/entity-web/UI_KEYCLOAK_RESOURCE_NAME" | ||
|
||
#vaults sentry | ||
# vaults sentry | ||
VUE_APP_SENTRY_DSN="op://sentry/$APP_ENV/entity/SENTRY_DSN" | ||
|
||
#vaults hotjar (hotjar id - ready to use) | ||
# vaults hotjar (hotjar id - ready to use) | ||
VUE_APP_HOTJAR_ID= | ||
VUE_APP_IA_SURVEY_ID="op://hotjar/$APP_ENV/shared/IA_SURVEY_ID" | ||
|
||
#vaults webchat | ||
# vaults webchat | ||
VUE_APP_GENESYS_ENV="op://webchat/$APP_ENV/base/GENESYS_ENV" | ||
VUE_APP_GENESYS_URL="op://webchat/$APP_ENV/base/GENESYS_URL" | ||
VUE_APP_GENESYS_ID="op://webchat/$APP_ENV/business-create-ui/GENESYS_ID" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ | |
{ "key" : "X-XSS-Protection", "value" : "1; mode=block" }, | ||
{ | ||
"key": "Content-Security-Policy", | ||
"value": "default-src 'self'; frame-src 'self' *.gov.bc.ca *.hotjar.com *.googleapis.com https://*.nr-data.net https://*.newrelic.com https://*.cac1.pure.cloud; script-src 'self' 'unsafe-eval' 'unsafe-inline' *.gov.bc.ca *.hotjar.com *.googleapis.com https://*.nr-data.net https://*.newrelic.com https://*.cac1.pure.cloud; style-src 'self' 'unsafe-inline' *.cloudflare.com *.googleapis.com; font-src 'self' *.gov.bc.ca *.hotjar.com *.cloudflare.com *.googleapis.com *.gstatic.com *.jsdelivr.net; img-src 'self' data: *.hotjar.com https://*.cac1.pure.cloud; connect-src 'self' *.gov.bc.ca *.launchdarkly.com *.hotjar.com *.postescanada-canadapost.ca *.sentry.io *.apigee.net wss://*.hotjar.com *.hotjar.io https://*.nr-data.net https://shyrka-prod-cac1.s3.ca-central-1.amazonaws.com https://*.newrelic.com https://*.cac1.pure.cloud wss://*.cac1.pure.cloud; manifest-src 'self'; media-src 'self' https://*.cac1.pure.cloud; object-src 'self' https://*.cac1.pure.cloud; child-src 'self' https://*.cac1.pure.cloud;" | ||
"value": "default-src 'self'; frame-src 'self' *.gov.bc.ca *.hotjar.com *.googleapis.com https://*.nr-data.net https://*.newrelic.com https://*.cac1.pure.cloud; script-src 'self' 'unsafe-eval' 'unsafe-inline' *.gov.bc.ca *.hotjar.com *.googleapis.com https://*.nr-data.net https://*.newrelic.com https://*.cac1.pure.cloud; style-src 'self' 'unsafe-inline' *.cloudflare.com *.googleapis.com; font-src 'self' *.gov.bc.ca *.hotjar.com *.cloudflare.com *.googleapis.com *.gstatic.com *.jsdelivr.net; img-src 'self' data: *.hotjar.com https://*.cac1.pure.cloud; connect-src 'self' *.gov.bc.ca *.run.app *.launchdarkly.com *.hotjar.com *.postescanada-canadapost.ca *.sentry.io *.apigee.net wss://*.hotjar.com *.hotjar.io https://*.nr-data.net https://shyrka-prod-cac1.s3.ca-central-1.amazonaws.com https://*.newrelic.com https://*.cac1.pure.cloud wss://*.cac1.pure.cloud; manifest-src 'self'; media-src 'self' https://*.cac1.pure.cloud; object-src 'self' https://*.cac1.pure.cloud; child-src 'self' https://*.cac1.pure.cloud;" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will need to be updated when merging to main branch. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @argush3 ^^ (Need to remove connect-src |
||
}, | ||
{ "key": "Cache-Control", "value": "no-cache, no-store, must-revalidate"}, | ||
{ "key": "Pragma", "value": "no-cache"}, | ||
|
severinbeauvais marked this conversation as resolved.
Show resolved
Hide resolved
|
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -320,6 +320,7 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi | |
@Action(useStore) setLastAnnualReportDate!: (x: string) => void | ||
@Action(useStore) setLastDirectorChangeDate!: (x: string) => void | ||
@Action(useStore) setNameRequest!: (x: NameRequestIF) => void | ||
@Action(useStore) setOperatingName!: (x: string) => void | ||
@Action(useStore) setParties!: (x: Array<PartyIF>) => void | ||
@Action(useStore) setResources!: (x: ResourceIF) => void | ||
@Action(useStore) setUserAddress!: (x: AddressIF) => void | ||
|
@@ -361,7 +362,7 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi | |
readonly window = window | ||
|
||
/** The Update Current JS Date timer id. */ | ||
private updateCurrentJsDateId = 0 | ||
private updateCurrentJsDateId = null as any // NodeJS.Timeout | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
/** The route breadcrumbs list. */ | ||
get breadcrumbs (): Array<BreadcrumbIF> { | ||
|
@@ -810,7 +811,7 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi | |
// NB: will throw if API error | ||
let draftFiling = await LegalServices.fetchFirstTask(businessId) | ||
|
||
this.setFilingType(draftFiling.header.name) | ||
this.setFilingType(draftFiling.header.name as FilingTypes) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed warning because name is a string. |
||
|
||
// check if filing is in a valid state to be edited | ||
this.invalidFilingDialog = !this.hasValidFilingState(draftFiling) | ||
|
@@ -866,7 +867,7 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi | |
// NB: will throw if API error | ||
let draftFiling = await LegalServices.fetchFirstOrOnlyFiling(tempId) | ||
|
||
this.setFilingType(draftFiling.header.name) | ||
this.setFilingType(draftFiling.header.name as FilingTypes) | ||
|
||
// check if filing is in a valid state to be edited | ||
this.invalidFilingDialog = !this.hasValidFilingState(draftFiling) | ||
|
@@ -1158,16 +1159,21 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi | |
|
||
// FUTURE: change this to a single setter/object? | ||
this.setAdminFreeze(business.adminFreeze) | ||
this.setLegalName(business.legalName) | ||
this.setEntityState(business.state) | ||
{ | ||
// store operating name if it exists (only used for firms atm) | ||
const alternateName = business.alternateNames?.find(x => x.identifier === business.identifier) | ||
if (alternateName) this.setOperatingName(alternateName.operatingName) | ||
} | ||
this.setBusinessNumber(business.taxId || null) // may be empty | ||
this.setBusinessStartDate(business.startDate) | ||
this.setEntityState(business.state) | ||
this.setGoodStanding(business.goodStanding) | ||
this.setIdentifier(business.identifier) | ||
this.setLastAnnualReportDate(business.lastAnnualReportDate) // may be empty | ||
this.setLastAddressChangeDate(business.lastAddressChangeDate) // may be empty | ||
this.setLastAnnualReportDate(business.lastAnnualReportDate) // may be empty | ||
this.setLastDirectorChangeDate(business.lastDirectorChangeDate) // may be empty | ||
this.setLegalName(business.legalName) | ||
this.setWarnings(Array.isArray(business.warnings) ? business.warnings : []) | ||
this.setGoodStanding(business.goodStanding) | ||
this.setBusinessStartDate(business.startDate) | ||
} | ||
|
||
/** Fetches authorizations and verifies roles. */ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
sm="3" | ||
class="pr-4" | ||
> | ||
<label>{{ entityLabel }}</label> | ||
<label id="entity-label">{{ entityLabel }}</label> | ||
</v-col> | ||
|
||
<v-col | ||
|
@@ -17,10 +17,15 @@ | |
class="mt-n1" | ||
> | ||
<label id="company-name">{{ entityName }}</label> | ||
<div class="my-1"> | ||
<div | ||
id="entity-description" | ||
class="my-1" | ||
> | ||
{{ entityDescription }} | ||
</div> | ||
<div>{{ getBusinessId }}</div> | ||
<div id="business-id"> | ||
{{ getBusinessId }} | ||
</div> | ||
</v-col> | ||
</v-row> | ||
</article> | ||
|
@@ -35,7 +40,7 @@ | |
sm="3" | ||
class="pr-4" | ||
> | ||
<label>{{ addressLabel }}</label> | ||
<label id="address-label">{{ addressLabel }}</label> | ||
</v-col> | ||
|
||
<v-col | ||
|
@@ -194,12 +199,12 @@ export default class AssociationDetails extends Mixins(CommonMixin, DateMixin) { | |
|
||
/** The entity name. */ | ||
get entityName (): string { | ||
return this.getBusinessLegalName || GetCorpNumberedDescription(this.getEntityType) | ||
return this.getBusinessLegalName || GetCorpNumberedDescription(this.getEntityType as any) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a mismatch between CorpTypeCd in GetCorpNumberedDescription() and CorpTypeCd from getEntityType that I couldn't figure out quickly so I just typed it as any. |
||
} | ||
|
||
/** The entity description. */ | ||
get entityDescription (): string { | ||
return GetCorpFullDescription(this.getEntityType) | ||
return GetCorpFullDescription(this.getEntityType as any) | ||
} | ||
|
||
/** The business start date. */ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be updated when merging to main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@argush3 ^^
... Whatever we end up doing for the new Legal (Name) API URL ...