24084 - Alteration Name/Type Change Logic (#596)

* don't show error when type changed by NR Signed-off-by: Qin <Arwen.Qin@gov.bc.ca> * update codes Signed-off-by: Qin <Arwen.Qin@gov.bc.ca> --------- Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
bcgov · Nov 7, 2024 · 5f75da1 · 5f75da1
1 parent ff80079
commit 5f75da1
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "business-edit-ui",
-  "version": "4.11.3",
+  "version": "4.11.4",
   "private": true,
   "appName": "Edit UI",
   "sbcName": "SBC Common Components",

diff --git a/src/components/common/YourCompany/ChangeBusinessType.vue b/src/components/common/YourCompany/ChangeBusinessType.vue
@@ -388,7 +388,8 @@ export default class ChangeBusinessType extends Mixins(CommonMixin) {
   }
 
   get nameRequestRequiredError (): boolean {
-    if (this.isNumberedCompany) {
+    // Don't show the Error when the type is changed by name
+    if (this.isNumberedCompany || this.isEntityTypeChangedByName) {
       return false
     }
     // Named companies to CC/CCC or ULC/CUL require a name request.

diff --git a/tests/unit/ChangeBusinessType.spec.ts b/tests/unit/ChangeBusinessType.spec.ts
@@ -179,6 +179,7 @@ describe('Change Business Type component', () => {
       }
     } as EntitySnapshotIF
     store.stateModel.tombstone.entityType = CorpTypeCd.BC_CCC
+    store.stateModel.tombstone.entityTypeChangedByName = false
 
     const wrapper: any = mount(ChangeBusinessType, { vuetify })
     wrapper.vm.isEditingType = true