24084 - Alteration Name/Type Change Logic

[ArwenQin]

Issue #: /bcgov/entity#24084
Description of changes:

• Don't show nameRequestRequiredError when the type change is by Changed Name

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

[ArwenQin]

/gcbrun

[ArwenQin]

After update:
The nameRequestRequiredError is not showing:

We can check the box and click done:

[bcregistry-sre]

Temporary Url for review: https://business-edit-dev--pr-596-b5vobzl5.web.app

[ArwenQin]

Test with: https://dev.business.bcregistry.gov.bc.ca/BC0871787

[severinbeauvais]

Test with: https://dev.business.bcregistry.gov.bc.ca/BC0871787

I tried changing business type to ULC, and checking the checkbox, but the Done button is still disabled.

I should be able to change the company name to allow the business type change to proceed: either with a BC -> ULC NR, or by changing to numbered. I didn't try the former, and the latter doesn't give me the right numbered name (it shows "xxx BC Ltd" instead of "xxx Unlimited Liability Company".

Finally, I saved by changes and reopened the alteration, and that didn't help. (Previously when I tested, saving and then reopening fixed some things.)

Make sure you test:

• numbered BC -> numbered ULC
• numbered BC -> named ULC
• named BC -> numbered ULC
• named BC -> named ULC
• other combinations (BEN, CCC)

[ArwenQin]

By the current change, I fixed Named BC -> Named ULC, by entering the NR.

However, Named BC -> Numbered ULC, by changing to numbered, will not work. It only works by filing 2 separate changes:
First step, change the Named BC to a numbered BC, file it;
Second step, change the numbered BC to a numbered ULC, and file it.

So a Named BC will change to "xxx BC Ltd" in the first step, just to change a named to a numbered, but can't change its type at the same type.

In summary:
numbered BC -> numbered ULC works, tested
numbered BC -> named ULC works, need to enter the NR
named BC -> numbered ULC needs 2 filings
named BC -> named ULC works, need to enter the NR

What do you think?

[severinbeauvais]

What do you think?

Can you figure out why it doesn't work, or what's needed to fix it?

I don't like needing 2 filings as that's twice the fees, but named BC → numbered ULC is possibly much less likely than named → named, so maybe it's OK. Or maybe it's OK for now and we can fix it further later.

Please check with Mihai and Olga.

[ArwenQin]

The reason is the current functionality only allows change from a named to a numbered by appending "B.C. Ltd." / or "UNLIMITED LIABILITY COMPANY", just same with the current legal type. It's not linking to the type change function.
Type changes, like a limited company to an ULC, doesn’t automatically trigger the name change to update.
To resolve this, we need to add logic that links these functions: selecting a change to ULC, then changing from a named company to a numbered one, should trigger the name to update to include "UNLIMITED LIABILITY COMPANY."

I will check with Olga and Mihai

[severinbeauvais]

The reason is the current functionality only allows change from a named to a numbered by appending "B.C. Ltd." / or "UNLIMITED LIABILITY COMPANY", just same with the current legal type. It's not linking to the type change function. Type changes, like a limited company to an ULC, doesn’t automatically trigger the name change to update. To resolve this, we need to add logic that links these functions: selecting a change to ULC, then changing from a named company to a numbered one, should trigger the name to update to include "UNLIMITED LIABILITY COMPANY."

I think you are on the right track: the name change needs to be linked to the type change. Question: should the user change name before type, or type before name, or it shouldn't matter?

[ArwenQin]

I am thinking about:
1.

• If the user changes the name before changing the type, the system updates the name to include "B.C. Ltd."
• When the user then changes the legal type, the name should update accordingly to reflect the new designation, don't show the error message, the user can click "Done".

• If the user tries to change the type before updating the name, show the error message, and they can't click "Done."
• Then the user needs to change the name, it should automatically adjust to "UNLIMITED LIABILITY COMPANY" to match the type change.

[severinbeauvais]

I am thinking about:

How does it work when you use a NR -- can you use a NR first and then change type, or does it have to be the other way around?

I think option 2 makes the most sense. We have to make sure there is a note that says the name (/number) must be changed before they can click Done.

[ArwenQin]

When use a NR:
1.

• If the user enters the NR directly (without choosing legal type change), the legal type change is automatically updated, and can't be edited.

• If the user select legal type change before entering the NR, the error message shows;
• The user can enter the NR now, and after it, the legal type change is automatically updated, and can't be edited.

For NR to numbered, I think both scenario 1 and 2 can happen. For scenario 2, when the error message shows, we can add a note that says the name (/number) must be changed before they can click Done.

[severinbeauvais]

Arwen, can you please summarize all possibly scenarios/flows along with what works and what doesn't? It will help me and when explaining to Mihai/Olga.

My goals are: clarity, consistency and correctness :)

[ArwenQin]

Hi Severin, in summary:

1. named BC -> named ULC
   I fixed it in this current ticket.

• Flow 1 - user enters the NR directly (without choosing legal type change):
  a. the legal type change is automatically updated, and can't be edited.
  b. the error message doesn't show, user can click "Done"

• Flow 2 - user select legal type change before entering the NR:
  a. the error message shows, user can't click "Done";
  b. then the user can enter the NR now, and after it, the legal type change is automatically updated, and can't be edited, no error message and user can click "Done"

2. numbered BC -> numbered ULC
   User can directly change the legal type, then the company name updates accordingly, no error message.

3. numbered BC -> named ULC
   The user can directly enter the NR (similarly to named BC -> named ULC), then the legal type change is automatically updated and can't be edited.

4. named BC -> numbered ULC
   current: needs 2 filings
   First step, change the Named BC to a numbered BC, file it;
   Second step, change the numbered BC to a numbered ULC, and file it.

Possible flows after update:

• Flow 1 - the user changes the name before changing the legal type:
  a. the system updates the name to include "B.C. Ltd."
  b. then the user tries to change the legal type, the name should update accordingly to reflect the new designation, don't show the error message, the user can click "Done".

• Flow 2 - the user tries to change the type before updating the name to numbered
  a. show the error message, and they can't click "Done."
  b. Then the user can either enter the NR, or change the name to numbered. We can attach a note below the error message to notify the user.
  c. now the user changes the name to numbered, it should automatically adjust to "UNLIMITED LIABILITY COMPANY" to match the type change.

[ArwenQin]

Olga said
For now let's just fix the problem in the ticket description.
For the scenario you described in the comment, please create a separate ticket and link to the Go-live clean-up epic.

[severinbeauvais]

Olga said For now let's just fix the problem in the ticket description. For the scenario you described in the comment, please create a separate ticket and link to the Go-live clean-up epic.

OK, let's go with this. Please copy-paste your awesome summary from above into the ticket. Thanks!

[ArwenQin]

Created #24300 https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/24300

[ArwenQin]

@severinbeauvais shall we merge this PR now?

[severinbeauvais]

LGTM