13021 - Special Resolution #499
Conversation
|
Tech debt ticket: bcgov/entity#16489 |
|
Would be nice to get some other review approvals (otherwise I'm the code gatekeeper, and that's a team role). |
| @@ -1253,7 +1253,7 @@ export default class FilingTemplateMixin extends DateMixin { | |||
| name: documentsInfo?.certifiedRules?.name, | |||
| key: documentsInfo?.certifiedRules?.key, | |||
| url: entitySnapshot.businessDocuments?.documents?.certifiedRules, | |||
| previouslyInResolution: documentsInfo.certifiedRules?.includedInResolution, | |||
| previouslyInResolution: documentsInfo?.certifiedRules?.includedInResolution, | |||
There was a problem hiding this comment.
Another option is to only set to store if you know the object is valid (otherwise you leave the store with its initial values), for example:
if (variable I care about exists) {
set variable to store
}
// otherwise don't set to store
|
Just fixing the paper draft issue Severin pointed out |
…protection against undefined. Added in draft upload date.
|
I've made some minor changes. I'm seeing another problem unrelated to this commit. The time it takes for It was 4 minutes on this PR: 7 minutes: |
|
Merging, if you see any issues - can address it in another PR. |
I wouldn't rely too much on GH build times, but I have noticed builds taking longer locally -- ever since the new packages, I think. Sometimes I think my WSL VM runs out of memory, too. I'll keep an eye out but I haven't found what it is, yet. (I wouldn't mind trying out Vite, though.) |
Issue #: bcgov/entity#13021
Description of changes:
Changes to support Special Resolution filing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).