Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13021 - Special Resolution #499

Merged
merged 48 commits into from
May 24, 2023
Merged

13021 - Special Resolution #499

Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
a01585d
Changes to support draft for Special Resolution.
seeker25 Aug 29, 2022
3b32e44
Clean up.
seeker25 Aug 29, 2022
6d76bd6
Update package.json, needs bcrs update.
seeker25 Aug 29, 2022
8ee229f
Remove EmptyPersonIF
seeker25 Aug 29, 2022
640bda8
Changes based on feedback.
seeker25 Aug 30, 2022
763b273
Merge branch 'main' of https://github.com/bcgov/business-edit-ui into…
seeker25 Aug 30, 2022
b42cc2f
Remove unused action.
seeker25 Aug 30, 2022
7d274fa
Add in ($event)
seeker25 Aug 30, 2022
09c601b
more $event and missing text
seeker25 Aug 30, 2022
9f0eb04
Changes based on feedback
seeker25 Aug 30, 2022
4e3f1c0
Console log cleanup
seeker25 Aug 30, 2022
e5fc9bf
Fix for alteration being conditional.
seeker25 Aug 30, 2022
12fc648
Comment fix
seeker25 Aug 30, 2022
f651db9
grammar
seeker25 Aug 30, 2022
deb1869
Merge branch 'main' of https://github.com/bcgov/business-edit-ui into…
seeker25 Apr 14, 2023
f9e1763
Merge fixes, add in tooltip.
seeker25 Apr 14, 2023
78705a0
Merge branch 'main' of https://github.com/bcgov/business-edit-ui into…
seeker25 Apr 14, 2023
bd95719
Grab changes from 13231
seeker25 Apr 14, 2023
6e25dfc
Merge branch 'main' of https://github.com/bcgov/business-edit-ui into…
seeker25 Apr 14, 2023
a674ef6
Create HelpSpecialResolution component
seeker25 Apr 14, 2023
5331073
Merge branch 'main' of https://github.com/bcgov/business-edit-ui into…
seeker25 Apr 14, 2023
4d23562
init for draft pr
Jxio Apr 19, 2023
263252a
code bak
Jxio Apr 19, 2023
c240c75
solve conflicts
Jxio Apr 26, 2023
dcc5d10
Merge branch 'main' into 15475
Jxio Apr 26, 2023
b33b341
fix conflicts
Jxio Apr 26, 2023
d605c2c
5.0.0
Jxio Apr 26, 2023
8601521
Initial changes for special resolution changes.
seeker25 Apr 26, 2023
975382a
Remove debugger
seeker25 Apr 26, 2023
51ee50e
Merge branch '15475' of https://github.com/Jxio/business-edit-ui into…
seeker25 Apr 26, 2023
a5f4cff
Changes for special resolution.
seeker25 May 16, 2023
1b197c0
Merge branch 'main' of https://github.com/bcgov/business-edit-ui into…
seeker25 May 16, 2023
c49b141
Remove accessors + update package + package-lock.
seeker25 May 16, 2023
097e692
Fix resolution date max.
seeker25 May 16, 2023
f90cc3c
Typo
seeker25 May 16, 2023
ffecb52
cleanup / unit test fix
seeker25 May 16, 2023
6e6cf27
Fix unit test.
seeker25 May 16, 2023
f347e42
Tweak to resume from draft.
seeker25 May 16, 2023
27d07bb
Changes based on feedback.
seeker25 May 23, 2023
3a2e409
Merge branch 'main' of https://github.com/bcgov/business-edit-ui into…
seeker25 May 23, 2023
93e4140
Fix package.json new line.
seeker25 May 23, 2023
6ab185c
Fix unused references.
seeker25 May 23, 2023
11580e4
Fix empty components + merge changes.
seeker25 May 23, 2023
e903740
Conditional access
seeker25 May 23, 2023
79ccebc
More conditional access
seeker25 May 23, 2023
18e5f35
Changed a bit how to handle reading information from draft. Added in …
seeker25 May 24, 2023
2032e54
Minor tweak.
seeker25 May 24, 2023
de0bbcf
Remove unused interface.
seeker25 May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mixins/filing-template-mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1253,7 +1253,7 @@ export default class FilingTemplateMixin extends DateMixin {
name: documentsInfo?.certifiedRules?.name,
key: documentsInfo?.certifiedRules?.key,
url: entitySnapshot.businessDocuments?.documents?.certifiedRules,
previouslyInResolution: documentsInfo.certifiedRules?.includedInResolution,
previouslyInResolution: documentsInfo?.certifiedRules?.includedInResolution,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option is to only set to store if you know the object is valid (otherwise you leave the store with its initial values), for example:

if (variable I care about exists) {
  set variable to store
}
// otherwise don't set to store

uploaded: documentsInfo?.certifiedRules?.uploaded
})

Expand Down