remove unuse code and add more comments fix lint

bcgov · Jul 17, 2023 · b6d89ba · b6d89ba
1 parent adeb210
commit b6d89ba
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 14 deletions.
diff --git a/src/frontend/src/components/public/PIASubHeader/index.tsx b/src/frontend/src/components/public/PIASubHeader/index.tsx
@@ -123,10 +123,16 @@ function PIASubHeader({
   ]);
 
   useEffect(() => {
+    // If all reviews are acknowledged
+    // the current status is in final review and
+    // MPO too has acknowledged, the PIA can progress to complete.
     let reviewProgramAreaDone = false;
     if (pia?.status === PiaStatuses.FINAL_REVIEW) {
       const selectedRoles = pia?.review?.programArea?.selectedRoles || [];
-const reviewProgramAreaDone = selectedRoles.every((role) => pia?.review?.programArea?.reviews?.[role]?.isAcknowledged === true)
+      reviewProgramAreaDone = selectedRoles.every(
+        (role) =>
+          pia?.review?.programArea?.reviews?.[role]?.isAcknowledged === true,
+      );
     }
 
     if (

diff --git a/src/frontend/src/pages/PIAForm/index.tsx b/src/frontend/src/pages/PIAForm/index.tsx
@@ -653,11 +653,10 @@ const PIAFormPage = () => {
         }
       } else if (buttonValue === 'completePIA') {
         const updatedPia = await upsertAndUpdatePia({
-          // here not sure what status for this one, need to discuss
-
           status: PiaStatuses.COMPLETE,
         });
-        // need to revisit this part, what happen when complete PIA
+        // need to revisit this part, current route to pia_intake tab
+        // when complete PIA story done, will go to Complete PIA list page
         if (updatedPia?.id) {
           navigate(
             buildDynamicPath(routes.PIA_VIEW, {

diff --git a/src/frontend/src/utils/status.ts b/src/frontend/src/utils/status.ts
@@ -416,16 +416,6 @@ export const statusList = (pia: IPiaForm | null): StatusList => {
                 cancelLabel: 'Cancel',
               },
             },
-            {
-              status: 'COMPLETE',
-              modal: {
-                title: 'Submit for Completion',
-                description:
-                  'Once CPO has confirmed all necessary ministry reviews have occurred and data has been uploaded to the PID, PIA will move to “Complete” status.',
-                confirmLabel: 'Yes, submit',
-                cancelLabel: 'Cancel',
-              },
-            },
           ],
         },
       },