Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] allow changing status of a DELEGATED PIA from MPO_REVIEW to CPO_REVIEW #1374

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

kushal-arora-fw
Copy link
Contributor

Description

This PR includes the following proposed change(s):

Due to the change in the Product direction, allowing changing status of a DELEGATED PIA from MPO_REVIEW to CPO_REVIEW

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Updating Testing Framework(s)
  • Version change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@github-actions github-actions bot added the DPIA API PR contains changes to DPIA API label Jul 11, 2023
@kushal-arora-fw kushal-arora-fw merged commit 3ffcd1d into main Jul 11, 2023
9 checks passed
@kushal-arora-fw kushal-arora-fw deleted the allow-mpo-to-cpo-review-on-delegate branch July 11, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA API PR contains changes to DPIA API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants