Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UTOPIA-1288] only allow one idir user to review one program area selected role #1381

Merged
merged 9 commits into from
Jul 19, 2023

Conversation

binggaofw
Copy link
Contributor

Description

This PR includes the following proposed change(s):

  • see title, if a user(based on IDIR) already review a program area role, then all other role will become read only for this user
Screenshot 2023-07-13 at 8 19 36 AM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Updating Testing Framework(s)
  • Version change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Development Dependency Working Agreement

  • My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
  • My code DOES include the importing of new dependencies into the DPIA ecosystem
    If new dependencies are being introduced to the DPIA ecosystem:
  • The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
  • The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

  • N/A
  • I have performed a self-review of my own code
  • I have made corresponding changes to project documentation or diagrams that reflect my changes
  • New and existing unit tests pass locally with my changes
  • My code follows Airbnb React Style Guidelines

API Development Changes

  • N/A
  • I have performed a self-review of my own code
  • My code follows standards and practices outlined in the BC Government API Development Guidelines
  • New and existing unit tests pass locally with my changes
  • My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Definition of Done

@github-actions github-actions bot added the DPIA Web App PR contains changes to DPIA frontend app label Jul 13, 2023
Bottle7
Bottle7 previously approved these changes Jul 14, 2023
@kushal-arora-fw
Copy link
Contributor

The UX doesn't look good OR I guess, it was never defined for this scenario.

If a user has filled in review for one of the program area, then other reviews look N/A, blank and weird view state. I mean functionality works, and so approving.

@kushal-arora-fw
Copy link
Contributor

But I would recommend having UX give it a look once.

@binggaofw binggaofw dismissed stale reviews from kushal-arora-fw and Bottle7 via eed8260 July 17, 2023 17:57
@binggaofw binggaofw merged commit c6cadcb into main Jul 19, 2023
6 checks passed
@binggaofw binggaofw deleted the UTOPIA-1288 branch July 19, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA Web App PR contains changes to DPIA frontend app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants